Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

await a missed test failure, fix broken test #3245

Merged
merged 2 commits into from Feb 16, 2022
Merged

await a missed test failure, fix broken test #3245

merged 2 commits into from Feb 16, 2022

Commits on Feb 15, 2022

  1. await a missed test failure, skip broken test 

    This test should be failing but the error is lost because `throwsA` does
not force the test to wait until the condition is checked.
dart-lang/test#1670

Fix the pattern to use `await expectLater` instead of `await expect` so
the failure will show up. Skip the test for now.
    @natebosch
    natebosch committed Feb 15, 2022
    Copy the full SHA
    3dd838b View commit details
    Browse the repository at this point in the history

  2. Find an ambiguous element 

    Use an annotation that could resolve to a class from one of two imports.
    @natebosch
    natebosch committed Feb 15, 2022
    Copy the full SHA
    4ae50fa View commit details
    Browse the repository at this point in the history