Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug in build_test where the resolve* apis would leak unhandled async errors #2599

Merged
merged 4 commits into from
Jan 14, 2020
Merged

Fix a bug in build_test where the resolve* apis would leak unhandled async errors #2599

merged 4 commits into from
Jan 14, 2020

Commits on Jan 14, 2020

  1. Fix a bug in build_test where the resolve* apis would leak errors fro… 

    …m the action callback as unhandled async errors to client code
    @jakemac53
    jakemac53 committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    2b01369 View commit details
    Browse the repository at this point in the history

  2. minor cleanup

    @jakemac53
    jakemac53 committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    0d73d2a View commit details
    Browse the repository at this point in the history

  3. use catchError instead of runZoned with onError

    @jakemac53
    jakemac53 committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    99fd2f6 View commit details
    Browse the repository at this point in the history

  4. fix file-based-asset-reader-test

    @jakemac53
    jakemac53 committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    705de8e View commit details
    Browse the repository at this point in the history