Fix a bug in build_test where the resolve* apis would leak unhandled async errors #2599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m the action callback as unhandled async errors to client code
natebosch
reviewed
Jan 14, 2020
|
Looks like something else in the latest dev broke us - investigating. |
natebosch
approved these changes
Jan 14, 2020
|
bad dev release is causing the integration test failures - merging on red. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2596
Specifically if the
actioncallback throws any exceptions then we would leak those as unhandled async errors.We can't await the call to
runBuilderbecause that would block on thetearDownfuture which would hang tests.The solution is to just swallow all errors from the unawaited future, and rely on the
onDoneFuture to report most errors. We try/catch the action callback and forward the errors to theonDonecompleter.