Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQTT Pubsub Certification Testing + AutAckOff Fix for MQTT #1420

Merged
merged 4 commits into from Jan 7, 2022

Conversation

shivamkm07
Copy link
Contributor

@shivamkm07 shivamkm07 commented Jan 7, 2022

Description

This is for Certification Test for MQTT PubSub component. It also redirects MQTT client pointer to a fork of upstream MQTT V3, containing a fix that's not merged yet.

Issue reference:

The issues this PR will close: #952 #1234

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

Signed-off-by: shivam <shivamkm07@gmail.com>
Signed-off-by: shivam <shivamkm07@gmail.com>
@shivamkm07 shivamkm07 requested review from a team as code owners January 7, 2022 05:59
Signed-off-by: shivam <shivamkm07@gmail.com>
@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #1420 (83955a1) into master (265fa9a) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1420      +/-   ##
==========================================
- Coverage   35.11%   35.11%   -0.01%     
==========================================
  Files         152      152              
  Lines       13501    13502       +1     
==========================================
  Hits         4741     4741              
- Misses       8258     8259       +1     
  Partials      502      502              
Impacted Files Coverage Δ
pubsub/mqtt/mqtt.go 26.20% <0.00%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5f1d86...83955a1. Read the comment docs.

@dapr-bot dapr-bot merged commit 4631d6e into dapr:master Jan 7, 2022
@msfussell msfussell added this to the v1.6 milestone Jan 20, 2022
jigargandhi pushed a commit to jigargandhi/components-contrib that referenced this pull request Jan 21, 2022
* MQTT Certification Test

Signed-off-by: shivam <shivamkm07@gmail.com>

* Using paho.mqtt.golang fork with AutoAck fix

Signed-off-by: shivam <shivamkm07@gmail.com>

* Adding MQTT component in certification.yml

Signed-off-by: shivam <shivamkm07@gmail.com>

Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
Signed-off-by: jigargandhi <jigarr.gandhi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create certification test MQTT as GA in pubsub
4 participants