Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating paho.mqtt.golang to fixed fork #4111

Merged
merged 2 commits into from
Jan 11, 2022
Merged

Conversation

shivamkm07
Copy link
Contributor

Signed-off-by: shivam shivamkm07@gmail.com

Description

This is to update mqtt library paho.mqtt.golang pointer to the fork having AutoAck fix.

Issue reference

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

Signed-off-by: shivam <shivamkm07@gmail.com>
@shivamkm07 shivamkm07 requested review from a team as code owners January 10, 2022 08:26
@daixiang0
Copy link
Member

@shivamkm07 could you share more background here?

@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #4111 (d39a445) into master (d2d263b) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4111      +/-   ##
==========================================
- Coverage   63.20%   63.17%   -0.04%     
==========================================
  Files         101      101              
  Lines        9654     9654              
==========================================
- Hits         6102     6099       -3     
- Misses       3073     3075       +2     
- Partials      479      480       +1     
Impacted Files Coverage Δ
pkg/actors/internal/placement.go 87.56% <0.00%> (-1.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2d263b...d39a445. Read the comment docs.

@shivamkm07
Copy link
Contributor Author

@shivamkm07 could you share more background here?

@daixiang0 Recent MQTT Pubsub component change merged in dapr/components contrib(dapr/components-contrib#1420) redirects MQTT client pointer to a fork of upstream MQTT V3, containing a fix that's not merged yet(in upstream/dependency).

The current PR is to just have the same pointer change to fork, otherwise dapr build would fail using the latest master of dapr/components-contrib.

@artursouza artursouza added the automerge Allows DaprBot to automerge and update PR if all approvals are in place label Jan 11, 2022
@yaron2 yaron2 merged commit 174a981 into dapr:master Jan 11, 2022
@yaron2 yaron2 added this to the v1.6 milestone Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Allows DaprBot to automerge and update PR if all approvals are in place
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants