Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RuboCop runtime errors #trivial #1391

Merged
merged 1 commit into from
Oct 23, 2022
Merged

Fix RuboCop runtime errors #trivial #1391

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 3 additions & 7 deletions .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,20 +14,16 @@ Style/StringLiterals:
Style/ClassCheck:
EnforcedStyle: kind_of?

# It's better to be more explicit about the type
Style/BracesAroundHashParameters:
Enabled: false

Comment on lines -17 to -20
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cop in question has been removed below:

# specs sometimes have useless assignments, which is fine
Lint/UselessAssignment:
Exclude:
- '**/spec/**/*'

# We could potentially enable the 2 below:
Layout/IndentHash:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been renamed as follows:

Layout/FirstHashElementIndentation:
Enabled: false

Layout/AlignHash:
Layout/HashAlignment:
Enabled: false

# HoundCI doesn't like this rule
Expand Down Expand Up @@ -149,5 +145,5 @@ Security/YAMLLoad:
Style/RaiseArgs:
Enabled: false

Layout/IndentHeredoc:
Layout/HeredocIndentation:
Enabled: false