Fix RuboCop runtime errors #trivial #1391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following error occurred when currently running the RuboCop, so this PR is fixed this error. ``` bundle exec rubocop .rubocop.yml: Metrics/LineLength has the wrong namespace - should be Layout .rubocop.yml: Style/FileName has the wrong namespace - should be Naming /Users/yudai.takada/ydah/danger/.rubocop.yml: Warning: no department given for PercentLiteralDelimiters. Error: The `Layout/AlignHash` cop has been renamed to `Layout/HashAlignment`. (obsolete configuration found in .rubocop.yml, please update it) The `Layout/IndentHash` cop has been renamed to `Layout/FirstHashElementIndentation`. (obsolete configuration found in .rubocop.yml, please update it) The `Layout/IndentHeredoc` cop has been renamed to `Layout/HeredocIndentation`. (obsolete configuration found in .rubocop.yml, please update it) The `Style/BracesAroundHashParameters` cop has been removed. (obsolete configuration found in .rubocop.yml, please update it) ```
ydah
commented
Oct 23, 2022
Comment on lines
-17
to
-20
| # It's better to be more explicit about the type | ||
| Style/BracesAroundHashParameters: | ||
| Enabled: false | ||
|
|
There was a problem hiding this comment.
The cop in question has been removed below:
ydah
commented
Oct 23, 2022
| # specs sometimes have useless assignments, which is fine | ||
| Lint/UselessAssignment: | ||
| Exclude: | ||
| - '**/spec/**/*' | ||
|
|
||
| # We could potentially enable the 2 below: | ||
| Layout/IndentHash: |
There was a problem hiding this comment.
It has been renamed as follows:
|
Thanks, looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following error occurred when currently running the RuboCop, so this PR is fixed this error.