Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #21695 terminate runs #21775

Merged
merged 5 commits into from May 22, 2024
Merged

Conversation

baumann-t
Copy link
Contributor

Summary

This PR adds an extra method to the DagsterGraphQL python client to enable the possibility to terminate multiple runs at the same time.

This PR is related to the following issue: #21695

How I Tested These Changes

The PR contains a suit of unit tests similar to the other methods defined on the client, testing multiple edge cases for error handling.

@gibsondan
Copy link
Member

Hi @baumann-t - thanks for sending this out. It looks like this needs a 'make ruff' and dagster-graphql-client query snapshot - can you run those and re-submit?

@baumann-t
Copy link
Contributor Author

baumann-t commented May 16, 2024

Hello @gibsondan! I've run make ruff and dagster-graphql-client query snapshot, let me know if this is ok with you now!

@garethbrickman garethbrickman requested review from gibsondan and removed request for gibsondan May 17, 2024 14:10
Copy link
Member

@gibsondan gibsondan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baumann-t I realized one thing from looking at your query again - I don't think the TERMINATE_RUNS_JOB_MUTATION mutation is actually using the termationPolicy argument? you could either add it to the graphql query (being sure to re-run the snapshot command again) or remove it from the python

@baumann-t
Copy link
Contributor Author

@gibsondan good catch thank you!.
I removed it for now to keep it consistent with the other function terminate_run. If we want to, we could add it to both as well

Copy link
Member

@gibsondan gibsondan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@gibsondan gibsondan merged commit 2748cc1 into dagster-io:master May 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dagster-graphql] Add method for terminating job runs to DagsterGraphQLClient
2 participants