New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dagster-graphql] Add method for terminating job runs to DagsterGraphQLClient #21695
Comments
Hello @garethbrickman Just to clarify the required enhancements: The function terminate_run already exists in the client, as seen here: terminate_run function. Would you like to add a terminate_runs function to the client that can handle multiple Run IDs simultaneously, similar to the terminateRuns mutation in the GraphQL API? If so, I'm ready to start working on this feature. Please let me know if you have any specific requirements or suggestions! Thank you! |
@baumann-t Thanks for pointing that out! I'll make a PR to update the docs to show that function is indeed available. Would be great to work on a |
Good morning @garethbrickman, I just opened a PR for the Let me know what you think! |
@baumann-t Amazing thank you! Will block some time to review this next week. I'll keep you posted in the PR 👍 |
## Summary This PR adds an extra method to the DagsterGraphQL python client to enable the possibility to terminate multiple runs at the same time. This PR is related to the following issue: #21695 ## How I Tested These Changes The PR contains a suit of unit tests similar to the other methods defined on the client, testing multiple edge cases for error handling.
What's the use case?
The GraphQL API itself has a
terminateRun
mutation documented here as well as aterminateRuns
mutation that can take multiple Run IDs.Both of these should be supported in the GraphQL Python Client.
Ideas of implementation
No response
Additional information
No response
Message from the maintainers
Impacted by this issue? Give it a 👍! We factor engagement into prioritization.
The text was updated successfully, but these errors were encountered: