Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve deprecation warnings for example-basic-pnpm #666

Merged
merged 1 commit into from Dec 15, 2022

Conversation

MikeMcC399
Copy link
Collaborator

This PR resolves the deprecation warnings produced by running .github/workflows/example-basic-pnpm.yml. It solves one item of issue #648 "Deprecated Ubuntu 18.04 used in example workflows".

Previous deprecation warnings

The previous deprecation warnings, for instance in run 3643305664, were:

"Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions/checkout@v2"

and

"The ubuntu-18.04 environment is deprecated, consider switching to ubuntu-20.04(ubuntu-latest), or ubuntu-22.04 instead. For more details see actions/runner-images#6002"

Remaining warning

The remaining warning is:

"macOS-latest pipelines will use macOS-12 soon. For more details, see actions/runner-images#6384"

There is nothing which needs to be done about this warning as the action is already successfully running macOS 12.6.1 through macOS-latest. It can be considered as a pure info message.

Name correction

In addition, since the workflow duplicated the name "example-basic" as it shows on the list https://github.com/cypress-io/github-action/actions, the name in the workflow has been extended to "example-basic-pnpm" which aligns with the filename "example-basic-pnpm.yml" of the action.

@MikeMcC399
Copy link
Collaborator Author

Submitted as draft. Waiting first for higher priority PRs to be merged.

@jaffrepaul
Copy link
Member

Thanks @MikeMcC399! This can be rebased with master where the version bumps were handled 👍

@MikeMcC399
Copy link
Collaborator Author

@jaffrepaul

I have rebased on master as you suggested. I was however waiting for the firefox issue (PR #660) to be resolved before putting any more of the draft PRs up for review. It would be nice to reach a baseline of all tests passing before going after more of the issues.

@jaffrepaul
Copy link
Member

Got it. PR #660 is merged!

Correct duplicated workflow name to example-basic-pnpm
Replace Ubuntu 18.04/20.04 combination by Ubuntu 20.04 / 22.04
Bump actions/checkout@v2 to v3 to mitigate Node.js 12 deprecation warning
@MikeMcC399 MikeMcC399 marked this pull request as ready for review December 15, 2022 17:30
@MikeMcC399
Copy link
Collaborator Author

The action log 3706463579 shows success, so this PR is also ready for merge.

Copy link
Member

@jaffrepaul jaffrepaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jaffrepaul jaffrepaul merged commit 3ab3d50 into cypress-io:master Dec 15, 2022
@MikeMcC399 MikeMcC399 deleted the update/example-basic-pnpm branch December 15, 2022 20:07
@github-actions
Copy link

🎉 This PR is included in version 5.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

kodiakhq bot added a commit to weareinreach/InReach that referenced this pull request Dec 20, 2022
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [actions/checkout](https://togithub.com/actions/checkout) | action | digest | `7dd9e2a` -> `755da8c` |
| [chromaui/action](https://togithub.com/chromaui/action) | action | digest | `0ec8cd8` -> `2440d35` |
| [cypress-io/github-action](https://togithub.com/cypress-io/github-action) | action | patch | `v5.0.0` -> `v5.0.2` |
| [github/codeql-action](https://togithub.com/github/codeql-action) | action | digest | `a669cc5` -> `959cbb7` |
| [tinkurlab/monorepo-pr-labeler-action](https://togithub.com/tinkurlab/monorepo-pr-labeler-action) | action | patch | `4.1.2` -> `4.1.3` |

---

### Release Notes

<details>
<summary>cypress-io/github-action</summary>

### [`v5.0.2`](https://togithub.com/cypress-io/github-action/releases/tag/v5.0.2)

[Compare Source](https://togithub.com/cypress-io/github-action/compare/v5.0.1...v5.0.2)

Numerous housekeeping updates to bring this action back up to speed.

\*In combination with v5.0.1, which triggered without a new dist build.

👏 Special thanks to [@&#8203;MikeMcC399](https://togithub.com/MikeMcC399) for all the diligent work! 👏

**Fix Failed Tests**

-   [cypress-io/github-action#643
-   [cypress-io/github-action#658
-   [cypress-io/github-action#660

**Update Dependencies**

-   [cypress-io/github-action#644
-   [cypress-io/github-action#650

**Resolve Warnings**

-   [cypress-io/github-action#651
-   [cypress-io/github-action#666
-   [cypress-io/github-action#670
-   [cypress-io/github-action#675

**Docs/Example Updates**

-   [cypress-io/github-action#665
-   [cypress-io/github-action#668

**Tooling Updates:**

-   [cypress-io/github-action#667
-   [cypress-io/github-action#677

### [`v5.0.1`](https://togithub.com/cypress-io/github-action/releases/tag/v5.0.1)

[Compare Source](https://togithub.com/cypress-io/github-action/compare/v5.0.0...v5.0.1)

##### Bug Fixes

-   correct .gitignore for videos and screenshots ([89e59e5](https://togithub.com/cypress-io/github-action/commit/89e59e5cfc7760513fe9e9ce4c690345d94eb27a))

</details>

<details>
<summary>tinkurlab/monorepo-pr-labeler-action</summary>

### [`v4.1.3`](https://togithub.com/TinkurLab/monorepo-pr-labeler-action/releases/tag/4.1.3): Monorepo PR Labeler v4.1.3

[Compare Source](https://togithub.com/tinkurlab/monorepo-pr-labeler-action/compare/4.1.2...4.1.3)

Changes include:

Bug fix to ignore directories starting with a dot `.` but not directories that contain a dot `.`. According to the docs, this action should ignore mono repos that begin with a dot but it currently ignores also mono repo with a dot even if it is not the first character. Thanks to [@&#8203;MoLow](https://togithub.com/MoLow) for the fix!

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/weareinreach/InReach).



PR-URL: #107
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants