Deprecated Ubuntu 18.04 used in example workflows

[MikeMcC399]

Where to find the issue

There are three workflows using the deprecated runner Ubuntu 18.04:

• .github/workflows/example-basic.yml
• .github/workflows/example-basic-pnpm.yml
• .github/workflows/example-firefox.yml (Fixed)

Describe the issue

GitHub workflows are using the deprecated ubuntu-18.04 runner image.

• GitHub ubuntu-18.04 runner is deprecated and will be fully unsupported by 2023-04-01.

• GitHub Ubuntu-latest workflows will use Ubuntu-22.04. Edit: completed on Dec 15, 2022.

Suggestion

• PR fix: update failed tests #643 incidentally addresses the issue with .github/workflows/example-firefox.yml by updating to ubuntu-latest. Edit: now changed to ubuntu-20.04.

Update the other two workflows to use ubuntu-22.04:

• .github/workflows/example-basic.yml
• .github/workflows/example-basic-pnpm.yml

In addition update:

• actions/checkout@v2 to v3

Consider for these two workflows if it is necessary to retain testing of two different versions of Ubuntu. In general it may be advantageous for all workflows to standardize on ubuntu-latest.

[MikeMcC399]

I would offer to submit a PR for this, however I am unsure if there is capacity on the maintainer side of this repository currently which could process PR submission. How are things looking in general here from the maintenance side?

The more I look, the more I see things which need updating!

[jaffrepaul]

I would offer to submit a PR for this, however I am unsure if there is capacity on the maintainer side of this repository currently which could process PR submission. How are things looking in general here from the maintenance side?

The more I look, the more I see things which need updating!

Thank you @MikeMcC399. I learned that pinning these Ubuntu runners to a specific version was to help with this issue. However, as you've noted this is now becoming outdated. -latest is still transitioning to ubuntu-22.04. So for the time being, we could update the pinned versions to latest and update the test which covers one version behind accordingly.

There is a new team of two aiming to get ALL Cypress tools and plugins back up to date. There are a number of things needing attention in the GHA. This will take some time but I encourage you to open PRs where you can!

[MikeMcC399]

@jaffrepaul

This will take some time but I encourage you to open PRs where you can!

I'm happy to hear that there is a team in place and thank you for your feedback and encouragement! I will start with a documentation update, to make a small improvement and to test my understanding of the submission process.

I'll follow up with a PR to fix the deprecated Ubuntu 18.04 version, however I would like to wait until you have merged your PR to fix failing workflows, so that I would be working from a clean base which is showing no errors. There is still plenty of time until Ubuntu 18.04 completely runs out of support.

[MikeMcC399]

.github/workflows/example-firefox.yml is fixed by PR #643.

The deprecation notice

"The ubuntu-18.04 environment is deprecated, consider switching to ubuntu-20.04(ubuntu-latest), or ubuntu-22.04 instead. For more details see actions/runner-images#6002"

no longer appears in the latest action log https://github.com/cypress-io/github-action/actions/runs/3643305659.

[MikeMcC399]

@jaffrepaul

To align with your change in #643 I would not use ubuntu-latest, instead most of the sub-tests would continue to run under ubuntu-20.04. For the sub-test groups running a combination of 18.04/20.04 I would change that to run 20.04/22.04.

If you can give me your confirmation that the above is what is required, then I will start the PR work.

[jaffrepaul]

@MikeMcC399 Agreed!

[MikeMcC399]

@jaffrepaul

• Thanks! I will wait for the workflows in my first PR (docs: bump versions in DEVELOPMENT.md #650) to be approved, so I can see that the process is working, then I will follow up with the Ubuntu 18.04 related work.

[MikeMcC399]

@jaffrepaul

• I have submitted Resolve deprecation warnings for example-basic #651 to cover the first correction. The workflows need approval again.
• Presumably each new PR will need individual workflow approval until one PR from me has been merged into master and I will get GH Contributor status for this repository.
• Due to the above I have held back the PR to correct example-basic-pnpm. The branch https://github.com/MikeMcC399/github-action/tree/update/example-basic-pnpm is ready to open a PR from.

[MikeMcC399]

• PR Resolve deprecation warnings for example-basic #651 is ready for review. The tests have run successfully 🙂 .

[MikeMcC399]

• PR Resolve deprecation warnings for example-basic-pnpm #666 now submitted for the second part of this issue.

I have left both PRs in Draft state, since they only solve a deprecation warning. The other PRs which solve workflow failures should be looked at first.

[MikeMcC399]

PRs are now ready for review

[MikeMcC399]

The following two PRs have been merged and this issue is therefore resolved:

• Resolve deprecation warnings for example-basic #651
• Resolve deprecation warnings for example-basic-pnpm #666