Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix set-output command warnings from GitHub #621

Merged
merged 1 commit into from Nov 22, 2022
Merged

fix set-output command warnings from GitHub #621

merged 1 commit into from Nov 22, 2022

Conversation

piotrekkr
Copy link
Contributor

@piotrekkr piotrekkr commented Nov 3, 2022 •
edited

fixes #613

@piotrekkr piotrekkr mentioned this pull request Nov 3, 2022
Closed
@mellis481
Copy link

@piotrekkr This PR calls out addressing the set-output command warnings, but I was seeing save-state warnings in my workflows that use cypress-io/github-action. Does this PR address that too since that's also a problem? https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

@piotrekkr
Copy link
Contributor Author

piotrekkr commented Nov 7, 2022 •
edited

@mellis481 It should also fix this set-state warning. Check release notes here https://github.com/actions/toolkit/blob/main/packages/core/RELEASES.md#1100

@max-nextcloud max-nextcloud mentioned this pull request Nov 9, 2022
Merged
@wkillerud wkillerud mentioned this pull request Nov 11, 2022
Closed
@PabloCollazoCollarte
Copy link

Any updated on this issue?

@piotrekkr
Copy link
Contributor Author

@admah Hello. Seems like you are able to merge pull request in this project so can you take a look and merge this PR? Thanks.

@piotrekkr
Copy link
Contributor Author

@mjhenkes @kevinold @bahmutov Hello. Maybe you could help with this? Thanks

@ray-peters
Copy link

@piotrekkr Thank you for your work!

@mjhenkes @bahmutov Could you please help move this along?

It would be great to resolve the warnings from github actions:

image

@mjhenkes mjhenkes merged commit 032c1ed into cypress-io:master Nov 22, 2022
@mjhenkes
Copy link
Member

@piotrekkr thanks for the PR!

@piotrekkr piotrekkr deleted the fix-github-warnings branch November 22, 2022 14:46
@piotrekkr
Copy link
Contributor Author

@mjhenkes Thanks for merging this. For now we should use master version for github action right? When do you plan on releasing new version with this fix?

@jaffrepaul
Copy link
Member

@mjhenkes Thanks for merging this. For now we should use master version for github action right? When do you plan on releasing new version with this fix?

@piotrekkr The release is normally triggered by the merge to master but the commit message was missing the ":" as part of the semantic-commit convention. Didn't spot that before the merge so I just kicked off a release manually.

@mellis481
Copy link

mellis481 commented Nov 22, 2022 •
edited

@piotrekkr I'm testing this change in one of my workflows now and the problem appears to still exist. FWIW, I still see set-output and save-state refs in dist/index.js. Is updating the @actions/core version in the package.json all that was really required to address this? Was this not tested with a beta release?

CC: @jaffrepaul @mjhenkes

@lwhiteley
Copy link

The PR didnt rebuild the action dist files..only updated the version.

you may need another PR to build the runnable artefacts

kodiakhq bot added a commit to weareinreach/InReach that referenced this pull request Nov 23, 2022
@kodiakhq @renovate
chore(workflows): update github actions (#70)
00110c5 
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [cypress-io/github-action](https://togithub.com/cypress-io/github-action) | action | patch | `v4.2.0` -> `v4.2.1` |
| [ruby/setup-ruby](https://togithub.com/ruby/setup-ruby) | action | minor | `v1.123.0` -> `v1.124.0` |

---

### Release Notes

<details>
<summary>cypress-io/github-action</summary>

### [`v4.2.1`](https://togithub.com/cypress-io/github-action/releases/tag/v4.2.1)

[Compare Source](https://togithub.com/cypress-io/github-action/compare/v4.2.0...v4.2.1)

##### Bug Fixes

-   **deps:** fix set-output command warnings from GitHub [cypress-io/github-action#621

</details>

<details>
<summary>ruby/setup-ruby</summary>

### [`v1.124.0`](https://togithub.com/ruby/setup-ruby/releases/tag/v1.124.0): Ignore Bundler dev version in Gemfile.lock

[Compare Source](https://togithub.com/ruby/setup-ruby/compare/v1.123.0...v1.124.0)

-   Fixes [ruby/setup-ruby#394

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/weareinreach/InReach).



PR-URL: #70
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@piotrekkr
Copy link
Contributor Author

@jaffrepaul @mellis481 @lwhiteley I did not know that I should rebuild dist. Not sure where it is in docs. Anyway fix is here: #638

@mellis481 mellis481 mentioned this pull request Nov 23, 2022
Merged
JoeKarow pushed a commit to weareinreach/InReach that referenced this pull request Dec 3, 2022
@kodiakhq @renovate
chore(workflows): update github actions (#70)
15c7a3c 
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [cypress-io/github-action](https://togithub.com/cypress-io/github-action) | action | patch | `v4.2.0` -> `v4.2.1` |
| [ruby/setup-ruby](https://togithub.com/ruby/setup-ruby) | action | minor | `v1.123.0` -> `v1.124.0` |

---

### Release Notes

<details>
<summary>cypress-io/github-action</summary>

### [`v4.2.1`](https://togithub.com/cypress-io/github-action/releases/tag/v4.2.1)

[Compare Source](https://togithub.com/cypress-io/github-action/compare/v4.2.0...v4.2.1)

##### Bug Fixes

-   **deps:** fix set-output command warnings from GitHub [cypress-io/github-action#621

</details>

<details>
<summary>ruby/setup-ruby</summary>

### [`v1.124.0`](https://togithub.com/ruby/setup-ruby/releases/tag/v1.124.0): Ignore Bundler dev version in Gemfile.lock

[Compare Source](https://togithub.com/ruby/setup-ruby/compare/v1.123.0...v1.124.0)

-   Fixes [ruby/setup-ruby#394

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/weareinreach/InReach).



PR-URL: #70
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@jaffrepaul jaffrepaul mentioned this pull request Jan 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjhenkes mjhenkes mjhenkes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update @actions/core dependency to >=1.10.0 to avoid deprecation warning
7 participants
@piotrekkr @mellis481 @PabloCollazoCollarte @ray-peters @mjhenkes @jaffrepaul @lwhiteley