Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @actions/core dependency to >=1.10.0 to avoid deprecation warning #613

Closed
dennisjlee opened this issue Oct 13, 2022 · 11 comments · Fixed by #621
Closed

Update @actions/core dependency to >=1.10.0 to avoid deprecation warning #613

dennisjlee opened this issue Oct 13, 2022 · 11 comments · Fixed by #621

Comments

@dennisjlee
Copy link

In a GitHub action where I use cypress-io/github-action@v4, I'm seeing this warning:

Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I think this would be addressed by upgrading @actions/core in package.json.

There is one usage of the setOutput method in the codebase, here.

@MikeMcC399
Copy link
Collaborator

MikeMcC399 commented Oct 20, 2022

The warning says "The set-output command is deprecated and will be disabled soon." which makes it sound urgent, however the text in the link https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ quotes the date of June 1, 2023:

image

Nevertheless it would be good to have cypress-io/github-action updated soon to avoid the warning appearing.

@jpita
Copy link

jpita commented Nov 2, 2022

is this fixed or still wip?

@lwhiteley
Copy link

is this fixed or still wip?

there are no pull requests addressing the issue currently
the package.json version of @actions/core has not been updated either

https://github.com/cypress-io/github-action/blob/master/package.json#L35

@piotrekkr
Copy link
Contributor

Possible fix in #621

@piotrekkr
Copy link
Contributor

piotrekkr commented Nov 22, 2022

Merged to master but not yet released. if you need version with this fix you should either use commit SHA or master as github action version or just wait for new release.

@MikeMcC399
Copy link
Collaborator

I am still seeing the warning message:

"The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/"

running with cypress-io/github-action@v4.2.1 corresponding to today's release v4.2.1.

I tried first with cypress-io/github-action@v4 and then tested with the explicit version above.

@piotrekkr
Copy link
Contributor

@MikeMcC399 Seems like I did not know that I also need to rebuild dist files. Fix is in #638

@MikeMcC399
Copy link
Collaborator

@piotrekkr

I also need to rebuild dist files. Fix is in #638

@piotrekkr
Copy link
Contributor

@MikeMcC399 I used piotrekkr/github-action@update-dist-files and I didn't get any warnings in GitHub from cypress action

@MikeMcC399
Copy link
Collaborator

@piotrekkr

Thanks for confirming your test and giving the syntax to access your fork. I also tested and found there is no warning any more. 👍🏻

@MikeMcC399
Copy link
Collaborator

@piotrekkr

  • Thanks for the follow-on PR fix: rebuild dist files #638!
  • I checked again using the merged version and everything is fine with uses: cypress-io/github-action@v4! No more warning message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants