Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix issue with open hook in IDE on rerun #8097

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Conversation

panzarino
Copy link
Contributor

User facing changelog

Fixes an issue where rerunning a test would cause the hooks Open in IDE button to disappear

Additional details

Having trouble writing a test for this since runner tests don't support rerunning yet

How has the user experience changed?

Before:

ezgif-6-ed0eff99d105

After:

ezgif-6-ccc6b187d7c3

PR Tasks

  • Have tests been added/updated?
  • Has the original issue been tagged with a release in ZenHub?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 28, 2020

Thanks for taking the time to open a PR!

@panzarino panzarino requested a review from bahmutov July 28, 2020 01:19
@jennifer-shehane jennifer-shehane changed the title Fix issue with open hook in IDE on rerun fix: Fix issue with open hook in IDE on rerun Jul 28, 2020
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually confirmed this fixes the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open hook in IDE button disappears on test rerun
2 participants