Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Recovered Error Handling and Session Recovered Errors #24511

Merged
merged 67 commits into from Nov 10, 2022
Merged

fix: Recovered Error Handling and Session Recovered Errors #24511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
67 commits
Select commit Hold shift + click to select a range
bd0a0ee
start
emilyrohrbough Sep 16, 2022
159e4ad
[skip ci]
emilyrohrbough Sep 22, 2022
fa44f35
some progress (branch appears out-of-date)
emilyrohrbough Sep 23, 2022
d6dde1c
Merge branch 'develop' into sessions-in-test-errors
emilyrohrbough Sep 23, 2022
1d3584d
Correctly handle errors thrown from cypress commands in session setup…
emilyrohrbough Sep 23, 2022
4dc9e6b
more granular error tests
emilyrohrbough Sep 23, 2022
0dfbb99
Merge branch 'develop' into sessions-in-test-errors
emilyrohrbough Oct 11, 2022
b10cdc4
Fix missed merge conflict & code check-in.
emilyrohrbough Oct 12, 2022
c2a1b5c
great time to check some code in! next steps...aligning the stack tra…
emilyrohrbough Oct 13, 2022
342f701
great checkin point -- going to cherry pick the UI changes out into t…
emilyrohrbough Oct 14, 2022
fea09e9
Merge branch 'develop' into sessions-in-test-errors
emilyrohrbough Oct 14, 2022
c868386
no ci
emilyrohrbough Oct 14, 2022
e25419b
feat: enhance test error UI
emilyrohrbough Oct 14, 2022
f09ba08
fix tests
emilyrohrbough Oct 14, 2022
85a2b07
Break this up a bit more
emilyrohrbough Oct 14, 2022
2b593de
clean up
emilyrohrbough Oct 14, 2022
db28fd1
minor style fixes in alignment & border color
emilyrohrbough Oct 17, 2022
bfa869f
Merge branch 'develop' into reporter-error-ui
emilyrohrbough Oct 17, 2022
9e7a463
Merge remote-tracking branch 'origin/reporter-error-ui' into sessions…
emilyrohrbough Oct 17, 2022
fdda301
minor padding tweaks
emilyrohrbough Oct 17, 2022
56f4c2a
Merge branch 'reporter-error-ui' of https://github.com/cypress-io/cyp…
emilyrohrbough Oct 17, 2022
2cd8cae
Merge remote-tracking branch 'origin/reporter-error-ui' into sessions…
emilyrohrbough Oct 17, 2022
0ab8846
tests for create session setup / validation errors
emilyrohrbough Oct 18, 2022
d51cc95
write test coverage for recreated sessions
emilyrohrbough Oct 20, 2022
cdafd9f
okay !!! I think we have fixed all the recovered states. check in dump
emilyrohrbough Oct 21, 2022
27ce5e4
no only to run in CI
emilyrohrbough Oct 21, 2022
338d3b8
CI doesnt even like .only in comments :(
emilyrohrbough Oct 21, 2022
b904344
okay check in point. Still not there yet
emilyrohrbough Oct 21, 2022
2446db9
:D whoops.
emilyrohrbough Oct 21, 2022
7d4e8e7
fix stack traces
emilyrohrbough Oct 24, 2022
18761c9
Merge branch 'develop' into sessions-in-test-errors
emilyrohrbough Oct 24, 2022
4902429
cleanup
emilyrohrbough Oct 24, 2022
898cab6
some progress. still not there. need to fix session tests & likely fi…
emilyrohrbough Oct 24, 2022
8d36df5
clean up.
emilyrohrbough Oct 25, 2022
5cf2ad7
Merge branch 'develop' into sessions-in-test-errors
emilyrohrbough Oct 25, 2022
c41e537
fix utils tests
emilyrohrbough Oct 25, 2022
44727c4
app tests are passing!!!
emilyrohrbough Oct 26, 2022
87ffa23
and this.
emilyrohrbough Oct 26, 2022
125df05
LETS GOOOOOOOOOOO!!!!! all my session tests are passing! lets see if …
emilyrohrbough Oct 26, 2022
c602c34
Merge branch 'develop' into sessions-in-test-errors
emilyrohrbough Oct 26, 2022
200b7f7
fix a handful of errors
emilyrohrbough Oct 26, 2022
e17ee7d
fix tests !!
emilyrohrbough Oct 27, 2022
7a490ba
and fix.
emilyrohrbough Oct 27, 2022
3719c91
handle multiple command queue errors
emilyrohrbough Nov 1, 2022
3789d5d
fix
emilyrohrbough Nov 1, 2022
0cdadc8
fix tests
emilyrohrbough Nov 1, 2022
7a3ece9
fix tests & some type errors
emilyrohrbough Nov 1, 2022
5b137ec
fix tests
emilyrohrbough Nov 1, 2022
f34fac4
fix types
emilyrohrbough Nov 2, 2022
d6a6f90
and fix code frames
emilyrohrbough Nov 2, 2022
c515ae0
Merge branch 'develop' into sessions-in-test-errors
emilyrohrbough Nov 3, 2022
28f6add
fix ensure exists to be a cypress error instead of an assertion error
emilyrohrbough Nov 3, 2022
443e311
snapshot cache
emilyrohrbough Nov 3, 2022
ff8deb5
Fix codeframe issue & redundant reported log message & error nesting.
emilyrohrbough Nov 4, 2022
4fe9cf0
address PR feedback
emilyrohrbough Nov 4, 2022
8952a2b
Merge branch 'develop' into sessions-in-test-errors
emilyrohrbough Nov 7, 2022
2921590
fix tests
emilyrohrbough Nov 8, 2022
3f2e50d
maintain error message parity with current cypress behavior.
emilyrohrbough Nov 8, 2022
1f87967
fix
emilyrohrbough Nov 8, 2022
e113104
fix
emilyrohrbough Nov 8, 2022
d1eee3a
fix test
emilyrohrbough Nov 8, 2022
2a7bb06
correct types
emilyrohrbough Nov 8, 2022
b8e919f
Merge branch 'develop' into sessions-in-test-errors
emilyrohrbough Nov 8, 2022
1d52b05
fix test for webkit & firefox
emilyrohrbough Nov 8, 2022
8584bda
Merge branch 'sessions-in-test-errors' of https://github.com/cypress-…
emilyrohrbough Nov 8, 2022
919dd4a
fix.
emilyrohrbough Nov 8, 2022
9172359
Merge branch 'develop' into sessions-in-test-errors
emilyrohrbough Nov 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion cli/types/cypress.d.ts
View file
Open in desktop
Expand Up @@ -670,7 +670,7 @@ declare namespace Cypress {
* If validation fails after restoring a session, `setup` will re-run.
* @default {false}
*/
validate?: () => Promise<false | void> | false | void
validate?: () => Promise<false | void> | void
}

type CanReturnChainable = void | Chainable | Promise<unknown>
Expand Down