Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Recovered Error Handling and Session Recovered Errors #24511

Merged
merged 67 commits into from Nov 10, 2022
Merged

fix: Recovered Error Handling and Session Recovered Errors #24511

merged 67 commits into from Nov 10, 2022

Commits on Sep 16, 2022

  1. start

    @emilyrohrbough
    emilyrohrbough committed Sep 16, 2022
    Copy the full SHA
    bd0a0ee View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2022

  1. [skip ci]

    @emilyrohrbough
    emilyrohrbough committed Sep 22, 2022
    Copy the full SHA
    159e4ad View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2022

  1. some progress (branch appears out-of-date)

    @emilyrohrbough
    emilyrohrbough committed Sep 23, 2022
    Copy the full SHA
    fa44f35 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into sessions-in-test-errors

    @emilyrohrbough
    emilyrohrbough committed Sep 23, 2022
    Copy the full SHA
    d6dde1c View commit details
    Browse the repository at this point in the history

  3. Correctly handle errors thrown from cypress commands in session setup… 

    … function.
    @emilyrohrbough
    emilyrohrbough committed Sep 23, 2022
    Copy the full SHA
    1d3584d View commit details
    Browse the repository at this point in the history

  4. more granular error tests

    @emilyrohrbough
    emilyrohrbough committed Sep 23, 2022
    Copy the full SHA
    4dc9e6b View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2022

  1. Merge branch 'develop' into sessions-in-test-errors 

    # Conflicts:
#	packages/app/cypress/e2e/runner/sessions.ui.cy.ts
#	packages/driver/cypress/e2e/commands/sessions/sessions.cy.js
#	packages/driver/src/cy/commands/sessions/index.ts
#	packages/driver/src/cypress/command_queue.ts
#	packages/driver/src/cypress/state.ts
    @emilyrohrbough
    emilyrohrbough committed Oct 11, 2022
    Copy the full SHA
    0dfbb99 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2022

  1. Fix missed merge conflict & code check-in.

    @emilyrohrbough
    emilyrohrbough committed Oct 12, 2022
    Copy the full SHA
    b10cdc4 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2022

  1. great time to check some code in! next steps...aligning the stack tra… 

    …ces with the line that failed.
    @emilyrohrbough
    emilyrohrbough committed Oct 13, 2022
    Copy the full SHA
    c2a1b5c View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2022

  1. great checkin point -- going to cherry pick the UI changes out into t… 

    …heir own PR
    @emilyrohrbough
    emilyrohrbough committed Oct 14, 2022
    Copy the full SHA
    342f701 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into sessions-in-test-errors 

    # Conflicts:
#	packages/driver/cypress/e2e/commands/sessions/sessions.cy.js
#	packages/driver/src/cypress/error_utils.ts
    @emilyrohrbough
    emilyrohrbough committed Oct 14, 2022
    Copy the full SHA
    fea09e9 View commit details
    Browse the repository at this point in the history

  3. no ci

    @emilyrohrbough
    emilyrohrbough committed Oct 14, 2022
    Copy the full SHA
    c868386 View commit details
    Browse the repository at this point in the history

  4. feat: enhance test error UI

    @emilyrohrbough
    emilyrohrbough committed Oct 14, 2022
    Copy the full SHA
    e25419b View commit details
    Browse the repository at this point in the history

  5. fix tests

    @emilyrohrbough
    emilyrohrbough committed Oct 14, 2022
    Copy the full SHA
    f09ba08 View commit details
    Browse the repository at this point in the history

  6. Break this up a bit more

    @emilyrohrbough
    emilyrohrbough committed Oct 14, 2022
    Copy the full SHA
    85a2b07 View commit details
    Browse the repository at this point in the history

  7. clean up

    @emilyrohrbough
    emilyrohrbough committed Oct 14, 2022
    Copy the full SHA
    2b593de View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2022

  1. minor style fixes in alignment & border color

    @emilyrohrbough
    emilyrohrbough committed Oct 17, 2022
    Copy the full SHA
    db28fd1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into reporter-error-ui

    @emilyrohrbough
    emilyrohrbough committed Oct 17, 2022
    Copy the full SHA
    bfa869f View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/reporter-error-ui' into sessions… 

    …-in-test-errors

# Conflicts:
#	packages/driver/cypress/e2e/commands/sessions/sessions.cy.js
#	packages/driver/src/cy/commands/sessions/index.ts
#	packages/driver/src/cypress/error_utils.ts
#	packages/driver/src/cypress/log.ts
#	packages/reporter/cypress/e2e/commands.cy.ts
#	packages/reporter/src/attempts/attempt-model.ts
#	packages/reporter/src/attempts/attempts.tsx
#	packages/reporter/src/commands/command-model.ts
#	packages/reporter/src/commands/command.tsx
#	packages/reporter/src/commands/commands.scss
#	packages/reporter/src/errors/err-model.ts
#	packages/reporter/src/errors/errors.scss
#	packages/reporter/src/errors/test-error.tsx
#	packages/reporter/src/lib/events.ts
#	packages/reporter/src/lib/variables.scss
    @emilyrohrbough
    emilyrohrbough committed Oct 17, 2022
    Copy the full SHA
    9e7a463 View commit details
    Browse the repository at this point in the history

  4. minor padding tweaks

    @emilyrohrbough
    emilyrohrbough committed Oct 17, 2022
    Copy the full SHA
    fdda301 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'reporter-error-ui' of https://github.com/cypress-io/cyp… 

    …ress into reporter-error-ui
    @emilyrohrbough
    emilyrohrbough committed Oct 17, 2022
    Copy the full SHA
    56f4c2a View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/reporter-error-ui' into sessions… 

    …-in-test-errors

# Conflicts:
#	packages/reporter/src/commands/commands.scss
#	packages/reporter/src/errors/errors.scss
    @emilyrohrbough
    emilyrohrbough committed Oct 17, 2022
    Copy the full SHA
    2cd8cae View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2022

  1. tests for create session setup / validation errors

    @emilyrohrbough
    emilyrohrbough committed Oct 18, 2022
    Copy the full SHA
    0ab8846 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2022

  1. write test coverage for recreated sessions

    @emilyrohrbough
    emilyrohrbough committed Oct 20, 2022
    Copy the full SHA
    d51cc95 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2022

  1. okay !!! I think we have fixed all the recovered states. check in dump

    @emilyrohrbough
    emilyrohrbough committed Oct 21, 2022
    Copy the full SHA
    cdafd9f View commit details
    Browse the repository at this point in the history

  2. no only to run in CI

    @emilyrohrbough
    emilyrohrbough committed Oct 21, 2022
    Copy the full SHA
    27ce5e4 View commit details
    Browse the repository at this point in the history

  3. CI doesnt even like .only in comments :(

    @emilyrohrbough
    emilyrohrbough committed Oct 21, 2022
    Copy the full SHA
    338d3b8 View commit details
    Browse the repository at this point in the history

  4. okay check in point. Still not there yet

    @emilyrohrbough
    emilyrohrbough committed Oct 21, 2022
    Copy the full SHA
    b904344 View commit details
    Browse the repository at this point in the history

  5. :D whoops.

    @emilyrohrbough
    emilyrohrbough committed Oct 21, 2022
    Copy the full SHA
    2446db9 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2022

  1. fix stack traces

    @emilyrohrbough
    emilyrohrbough committed Oct 24, 2022
    Copy the full SHA
    7d4e8e7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into sessions-in-test-errors 

    # Conflicts:
#	packages/driver/cypress/e2e/commands/sessions/sessions.cy.js
#	packages/driver/src/cy/commands/sessions/index.ts
#	packages/reporter/src/commands/command.tsx
#	packages/reporter/src/commands/commands.scss
#	packages/reporter/src/errors/errors.scss
#	packages/reporter/src/errors/test-error.tsx
    @emilyrohrbough
    emilyrohrbough committed Oct 24, 2022
    Copy the full SHA
    18761c9 View commit details
    Browse the repository at this point in the history

  3. cleanup

    @emilyrohrbough
    emilyrohrbough committed Oct 24, 2022
    Copy the full SHA
    4902429 View commit details
    Browse the repository at this point in the history

  4. some progress. still not there. need to fix session tests & likely fi… 

    …x codeframes still
    @emilyrohrbough
    emilyrohrbough committed Oct 24, 2022
    Copy the full SHA
    898cab6 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2022

  1. clean up.

    @emilyrohrbough
    emilyrohrbough committed Oct 25, 2022
    Copy the full SHA
    8d36df5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into sessions-in-test-errors 

    # Conflicts:
#	packages/driver/cypress/e2e/commands/sessions/sessions.cy.js
    @emilyrohrbough
    emilyrohrbough committed Oct 25, 2022
    Copy the full SHA
    5cf2ad7 View commit details
    Browse the repository at this point in the history

  3. fix utils tests

    @emilyrohrbough
    emilyrohrbough committed Oct 25, 2022
    Copy the full SHA
    c41e537 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2022

  1. app tests are passing!!!

    @emilyrohrbough
    emilyrohrbough committed Oct 26, 2022
    Copy the full SHA
    44727c4 View commit details
    Browse the repository at this point in the history

  2. and this.

    @emilyrohrbough
    emilyrohrbough committed Oct 26, 2022
    Copy the full SHA
    87ffa23 View commit details
    Browse the repository at this point in the history

  3. LETS GOOOOOOOOOOO!!!!! all my session tests are passing! lets see if … 

    …this works for the rest of cypress
    @emilyrohrbough
    emilyrohrbough committed Oct 26, 2022
    Copy the full SHA
    125df05 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into sessions-in-test-errors 

    # Conflicts:
#	packages/driver/src/cy/commands/sessions/index.ts
    @emilyrohrbough
    emilyrohrbough committed Oct 26, 2022
    Copy the full SHA
    c602c34 View commit details
    Browse the repository at this point in the history

  5. fix a handful of errors

    @emilyrohrbough
    emilyrohrbough committed Oct 26, 2022
    Copy the full SHA
    200b7f7 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2022

  1. fix tests !!

    @emilyrohrbough
    emilyrohrbough committed Oct 27, 2022
    Copy the full SHA
    e17ee7d View commit details
    Browse the repository at this point in the history

  2. and fix.

    @emilyrohrbough
    emilyrohrbough committed Oct 27, 2022
    Copy the full SHA
    7a490ba View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2022

  1. handle multiple command queue errors

    @emilyrohrbough
    emilyrohrbough committed Nov 1, 2022
    Copy the full SHA
    3719c91 View commit details
    Browse the repository at this point in the history

  2. fix

    @emilyrohrbough
    emilyrohrbough committed Nov 1, 2022
    Copy the full SHA
    3789d5d View commit details
    Browse the repository at this point in the history

  3. fix tests

    @emilyrohrbough
    emilyrohrbough committed Nov 1, 2022
    Copy the full SHA
    0cdadc8 View commit details
    Browse the repository at this point in the history

  4. fix tests & some type errors

    @emilyrohrbough
    emilyrohrbough committed Nov 1, 2022
    Copy the full SHA
    7a3ece9 View commit details
    Browse the repository at this point in the history

  5. fix tests

    @emilyrohrbough
    emilyrohrbough committed Nov 1, 2022
    Copy the full SHA
    5b137ec View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2022

  1. fix types

    @emilyrohrbough
    emilyrohrbough committed Nov 2, 2022
    Copy the full SHA
    f34fac4 View commit details
    Browse the repository at this point in the history

  2. and fix code frames

    @emilyrohrbough
    emilyrohrbough committed Nov 2, 2022
    Copy the full SHA
    d6a6f90 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2022

  1. Merge branch 'develop' into sessions-in-test-errors

    @emilyrohrbough
    emilyrohrbough committed Nov 3, 2022
    Copy the full SHA
    c515ae0 View commit details
    Browse the repository at this point in the history

  2. fix ensure exists to be a cypress error instead of an assertion error

    @emilyrohrbough
    emilyrohrbough committed Nov 3, 2022
    Copy the full SHA
    28f6add View commit details
    Browse the repository at this point in the history

  3. snapshot cache

    @emilyrohrbough
    emilyrohrbough committed Nov 3, 2022
    Copy the full SHA
    443e311 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2022

  1. Fix codeframe issue & redundant reported log message & error nesting.

    @emilyrohrbough
    emilyrohrbough committed Nov 4, 2022
    Copy the full SHA
    ff8deb5 View commit details
    Browse the repository at this point in the history

  2. address PR feedback

    @emilyrohrbough
    emilyrohrbough committed Nov 4, 2022
    Copy the full SHA
    4fe9cf0 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. Merge branch 'develop' into sessions-in-test-errors 

    # Conflicts:
#	tooling/v8-snapshot/cache/dev-darwin/snapshot-meta.cache.json
    @emilyrohrbough
    emilyrohrbough committed Nov 7, 2022
    Copy the full SHA
    8952a2b View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2022

  1. fix tests

    @emilyrohrbough
    emilyrohrbough committed Nov 8, 2022
    Copy the full SHA
    2921590 View commit details
    Browse the repository at this point in the history

  2. maintain error message parity with current cypress behavior.

    @emilyrohrbough
    emilyrohrbough committed Nov 8, 2022
    Copy the full SHA
    3f2e50d View commit details
    Browse the repository at this point in the history

  3. fix

    @emilyrohrbough
    emilyrohrbough committed Nov 8, 2022
    Copy the full SHA
    1f87967 View commit details
    Browse the repository at this point in the history

  4. fix

    @emilyrohrbough
    emilyrohrbough committed Nov 8, 2022
    Copy the full SHA
    e113104 View commit details
    Browse the repository at this point in the history

  5. fix test

    @emilyrohrbough
    emilyrohrbough committed Nov 8, 2022
    Copy the full SHA
    d1eee3a View commit details
    Browse the repository at this point in the history

  6. correct types

    @emilyrohrbough
    emilyrohrbough committed Nov 8, 2022
    Copy the full SHA
    2a7bb06 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'develop' into sessions-in-test-errors

    @emilyrohrbough
    emilyrohrbough committed Nov 8, 2022
    Copy the full SHA
    b8e919f View commit details
    Browse the repository at this point in the history

  8. fix test for webkit & firefox

    @emilyrohrbough
    emilyrohrbough committed Nov 8, 2022
    Copy the full SHA
    1d52b05 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'sessions-in-test-errors' of https://github.com/cypress-… 

    …io/cypress into sessions-in-test-errors
    @emilyrohrbough
    emilyrohrbough committed Nov 8, 2022
    Copy the full SHA
    8584bda View commit details
    Browse the repository at this point in the history

  10. fix.

    @emilyrohrbough
    emilyrohrbough committed Nov 8, 2022
    Copy the full SHA
    919dd4a View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2022

  1. Merge branch 'develop' into sessions-in-test-errors

    @emilyrohrbough
    emilyrohrbough committed Nov 10, 2022
    Copy the full SHA
    9172359 View commit details
    Browse the repository at this point in the history