Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: additionally set electron user agent through CDP #23721

Merged
merged 1 commit into from Sep 9, 2022

Conversation

AtofStryker
Copy link
Contributor

@AtofStryker AtofStryker commented Sep 8, 2022

User facing changelog

Additionally overrides the electron user agent via CDP if the userAgent config option is provided or experimentalModifyObstructiveThirdPartyCode is enabled.

Additional details

It looks like the changes in #22958 did not fully override the electron user agent as expected (see #23597). In addition to setting the userAgent via the Electron's webContents.session API, we now optimistically set the user agent via CDP, which resolves the issue entirely.

Steps to test

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 8, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Sep 8, 2022



Test summary

40028 0 3346 0Flakiness 3


Run details

Project cypress
Status Passed
Commit 7167873
Started Sep 9, 2022 4:59 PM
Ended Sep 9, 2022 5:15 PM
Duration 15:33 💡
OS Linux Debian - 11.3
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

config_env.cy.ts Flakiness
1 cy.origin- Cypress.config() > serializable > overwrites different values in secondary, even if the Cypress.config() value does not exist in the primary
events.cy.ts Flakiness
1 cy.origin > window:before:load event
spec_bridge.cy.ts Flakiness
1 visits foobar.com and types foobar inside an input

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants