New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User agent in Electron isn't fully overridden when providing the experimentalModifyObstructiveThirdPartyCode
option
#23597
Labels
topic: cy.origin
Problems or enhancements related to cy.origin command
Comments
AtofStryker
added
the
topic: cy.origin
Problems or enhancements related to cy.origin command
label
Aug 29, 2022
AtofStryker
added a commit
that referenced
this issue
Sep 7, 2022
AtofStryker
added a commit
that referenced
this issue
Sep 8, 2022
4 tasks
cypress-bot
bot
added
the
stage: needs review
The PR code is done & tested, needs review
label
Sep 8, 2022
AtofStryker
added a commit
that referenced
this issue
Sep 9, 2022
cypress-bot
bot
added
stage: pending release
and removed
stage: needs review
The PR code is done & tested, needs review
labels
Sep 9, 2022
The code for this is done in cypress-io/cypress#23721, but has yet to be released. |
AtofStryker
added a commit
that referenced
this issue
Sep 9, 2022
AtofStryker
added a commit
that referenced
this issue
Sep 9, 2022
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Current behavior
Inside Electron, it looks like some requests, in particular document requests, have the incorrect UA associated with the request.
Desired behavior
Cypress should override the user agent as expected in #22958 in all cases when Electron is run with
experimentalModifyObstructiveThirdPartyCode
option set to trueTest code to reproduce
Adding the following code after this line seems to resolve the issue, via setting the UA optimistically via CDP:
Cypress Version
10.6.0
Node version
v16.15.0
Operating System
macOS 12.4 (Monterey)
Debug Logs
Other
This doesn't seem to have an impact on Google login, which means the behavior may have changed
The text was updated successfully, but these errors were encountered: