Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update error to not indicate this 'usually' is due to deps #17112

Merged
merged 1 commit into from Jul 6, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 2 additions & 6 deletions cli/__snapshots__/errors_spec.js
Expand Up @@ -62,13 +62,9 @@ current message

----------

This is usually caused by a missing library or dependency.
This may be due to a missing library or dependency. https://on.cypress.io/required-dependencies

The error above should indicate which dependency is missing.

https://on.cypress.io/required-dependencies

If you are using Docker, we provide containers with all required dependencies installed.
Please refer to the error above for more detail.

----------

Expand Down
24 changes: 6 additions & 18 deletions cli/__snapshots__/verify_spec.js
Expand Up @@ -116,13 +116,9 @@ STRIPPED

Error: Cypress failed to start.

This is usually caused by a missing library or dependency.
This may be due to a missing library or dependency. https://on.cypress.io/required-dependencies

The error below should indicate which dependency is missing.

https://on.cypress.io/required-dependencies

If you are using Docker, we provide containers with all required dependencies installed.
Please refer to the error below for more details.

----------

Expand All @@ -138,13 +134,9 @@ Cypress Version: 1.2.3
exports['fails with no stderr 1'] = `
Error: Cypress failed to start.

This is usually caused by a missing library or dependency.

The error below should indicate which dependency is missing.
This may be due to a missing library or dependency. https://on.cypress.io/required-dependencies

https://on.cypress.io/required-dependencies

If you are using Docker, we provide containers with all required dependencies installed.
Please refer to the error below for more details.

----------

Expand Down Expand Up @@ -414,13 +406,9 @@ some weird indent

----------

This is usually caused by a missing library or dependency.

The error above should indicate which dependency is missing.

https://on.cypress.io/required-dependencies
This may be due to a missing library or dependency. https://on.cypress.io/required-dependencies

If you are using Docker, we provide containers with all required dependencies installed.
Please refer to the error above for more detail.

----------

Expand Down
16 changes: 4 additions & 12 deletions cli/lib/errors.js
Expand Up @@ -149,13 +149,9 @@ const invalidSmokeTestDisplayError = {

${hr}

This is usually caused by a missing library or dependency.
This may be due to a missing library or dependency. ${chalk.blue(requiredDependenciesUrl)}

The error above should indicate which dependency is missing.

${chalk.blue(requiredDependenciesUrl)}

If you are using Docker, we provide containers with all required dependencies installed.
Please refer to the error above for more detail.
`
},
}
Expand All @@ -164,13 +160,9 @@ const missingDependency = {
description: 'Cypress failed to start.',
// this message is too Linux specific
solution: stripIndent`
This is usually caused by a missing library or dependency.

The error below should indicate which dependency is missing.
This may be due to a missing library or dependency. ${chalk.blue(requiredDependenciesUrl)}

${chalk.blue(requiredDependenciesUrl)}

If you are using Docker, we provide containers with all required dependencies installed.
Please refer to the error below for more details.
`,
}

Expand Down