Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update error to not indicate this 'usually' is due to deps #17112

Merged
merged 1 commit into from Jul 6, 2021

Conversation

jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Jun 24, 2021

User facing changelog

We updated the messaging when Cypress fails to start to be clearer that it’s not always due to a dependency missing.

Additional Details

  • I see issues with this error message over and over. And most people mention that they have all dependencies - or they’re just running on a very normal machine and this happens.
  • I’d like it to be clearer that this error may happen for other reasons and that they should just read the error message for more detail. I think people ignore the error message because we strongly infer that it’s due to a dependency issue.

Some example issues:

Some example errors that are not due to missing deps

Command failed with UNKNOWN: C:\Users\EX13068\AppData\Local\Cypress\Cache\6.9.1\Cypress\Cypress.exe --smoke-test --ping=859
spawn UNKNOWN
#
# Fatal error in , line 0
#
Command was killed with SIGTRAP (Debugger breakpoint): /home/opensuse/.cache/Cypress/7.5.0/Cypress/Cypress --no-sandbox --smoke-test --ping=484
/home/ubuntu/.cache/Cypress/7.2.0/Cypress/Cypress: 1: Syntax error: word unexpected (expecting ")")
/home/robert/.cache/Cypress/6.3.0/Cypress/Cypress: 1: Syntax error: "(" unexpected

User experience

Before

Cypress failed to start.

This is usually caused by a missing library or dependency.

The error below should indicate which dependency is missing.

https://on.cypress.io/required-dependencies

If you are using Docker, we provide containers with all required dependencies installed.

----------

ERROR 

----------

After

Cypress failed to start.

This may be caused by a missing library or dependency. https://on.cypress.io/required-dependencies

Please refer to the error below for more detail.

----------

ERROR

----------

PR Tasks

  • Updated tests
  • Tag in Zenhub

@jennifer-shehane jennifer-shehane requested a review from a team as a code owner June 24, 2021 18:30
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 24, 2021

Thanks for taking the time to open a PR!

@jennifer-shehane jennifer-shehane requested review from chrisbreiding and kuceb and removed request for a team June 24, 2021 18:30
@cypress
Copy link

cypress bot commented Jun 24, 2021



Test summary

4120 0 53 1Flakiness 0


Run details

Project cypress
Status Passed
Commit 0893f28
Started Jul 6, 2021 3:04 PM
Ended Jul 6, 2021 3:15 PM
Duration 10:55 💡
OS Linux Debian - 10.8
Browser Firefox 88

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 7, 2021

Released in 7.7.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v7.7.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jul 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants