fix: Add autoEnd option to Cypress.Log Typescript definitions #15076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
|
|
emilgoldsmith
changed the title
emilgoldsmith
changed the title
bahmutov
approved these changes
Feb 12, 2021
|
Awesome, thanks for the quick turnaround on the PR! |
1 task
|
@bahmutov hi! Sorry just realized that I made a mistake, I guess that's what happens when you think you can do a quick "typo-ish" contribution without reading the guidelines, this was PRed into master, not develop, which I can see in the contribution guidelines is the "production branch", so not sure what the best remedy is there, my bad! |
|
Ughh I missed it too. Will handle it tomorrow
…Sent from my iPhone
On Feb 12, 2021, at 20:03, Emil Goldsmith Olesen ***@***.***> wrote:
@bahmutov hi! Sorry just realized that I made a mistake, I guess that's what happens when you think you can do a quick "typo-ish" contribution without reading the guidelines, this was PRed into master, not develop, which I can see in the contribution guidelines is the "production branch", so not sure what the best remedy is there, my bad!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Thank you! Will make sure to read the contribution guidelines thoroughly if I help out another time! |
bahmutov
pushed a commit
that referenced
this pull request
Feb 14, 2021
bahmutov
added a commit
that referenced
this pull request
Feb 14, 2021
#15087) Co-authored-by: Emil Goldsmith Olesen <emilgoldsmith94@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry if not respecting the contribution guidelines, but this is an issue/PR as I noticed the autoEnd option isn't in the typescript definitions for Cypress, and it was referenced in the webcast on Youtube by the Cypress team: https://www.youtube.com/watch?v=V-o8WzlwKmM
Tried adding it here with a sensible comment, does it look good?
EDIT: Unlazied myself and searched the issues and see that there's #9590 and actually also already a PR for this at #14220 but it seems like this PR is inactive? So I'll keep this up?
closes #9590 (though it doesn't address the lack of documentation)