Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'autoEnd' does not exist in type 'Partial<LogConfig>' #9590

Closed
mccataldo opened this issue Dec 9, 2020 · 7 comments · Fixed by #15087
Closed

'autoEnd' does not exist in type 'Partial<LogConfig>' #9590

mccataldo opened this issue Dec 9, 2020 · 7 comments · Fixed by #15087
Labels
type: typings Issue related to Cypress types (for TypeScript)

Comments

@mccataldo
Copy link

mccataldo commented Dec 9, 2020

Doing this:

// @ts-check
function someFn() {
  const log = Cypress.log({ autoEnd: false })
}

...results in this:

Argument of type '{ displayName: string; message: string; autoEnd: boolean; }' is not assignable to parameter of type 'Partial<LogConfig>'.
  Object literal may only specify known properties, and 'autoEnd' does not exist in type 'Partial<LogConfig>'.
@jennifer-shehane jennifer-shehane added the type: typings Issue related to Cypress types (for TypeScript) label Dec 10, 2020
@cypress-bot cypress-bot bot added the stage: ready for work The issue is reproducible and in scope label Dec 10, 2020
@jennifer-shehane
Copy link
Member

Yes, this appears to be missing. Feel free to open a PR. Check out our contributing doc.

@samueloakley
Copy link

@jennifer-shehane Looks like this is also missing from the API docs.
https://docs.cypress.io/api/cypress-api/cypress-log.html#Arguments
Is autoEnd documented somewhere else?

@jennifer-shehane
Copy link
Member

No, I only found it used in our actual codebase.

@cypress-bot cypress-bot bot added stage: work in progress and removed stage: ready for work The issue is reproducible and in scope labels Dec 17, 2020
@linkel
Copy link

linkel commented Dec 17, 2020

I have created a PR to add the type, hope that's alright: #14220

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 12, 2021

The code for this is done in cypress-io/cypress#15076, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 14, 2021

The code for this is done in cypress-io/cypress#15087, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 16, 2021

Released in 6.5.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v6.5.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Feb 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: typings Issue related to Cypress types (for TypeScript)
Projects
None yet
4 participants