Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): use per-pid filename for downloaded cypress zip #14952

Merged
merged 1 commit into from Feb 9, 2021

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Feb 5, 2021

User facing changelog

  • Fixed an issue that could cause failure when installing two Cypresses at the same time.

Additional details

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 5, 2021

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Feb 5, 2021



Test summary

3977 0 49 2


Run details

Project cypress
Status Passed
Commit 6b0051d
Started Feb 5, 2021 9:54 PM
Ended Feb 5, 2021 10:06 PM
Duration 11:27 💡
OS Linux Debian - 10.5
Browser Chrome 83

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how to manually test this, but this was the proposed change. I have a reproducible example I can check after it's released. #4595 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants