Skip to content

Commit

Permalink
fix(cli): use per-pid filename for downloaded cypress zip (#14952)
Browse files Browse the repository at this point in the history
  • Loading branch information
flotwig committed Feb 9, 2021
1 parent e338177 commit 09afc48
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion cli/lib/tasks/install.js
Expand Up @@ -153,7 +153,7 @@ const downloadAndUnzip = ({ version, installDir, downloadDir }) => {
throttle: 100,
onProgress: null,
}
const downloadDestination = path.join(downloadDir, 'cypress.zip')
const downloadDestination = path.join(downloadDir, `cypress-${process.pid}.zip`)
const rendererOptions = getRendererOptions()

// let the user know what version of cypress we're downloading!
Expand Down
2 changes: 1 addition & 1 deletion cli/test/lib/tasks/install_spec.js
Expand Up @@ -21,7 +21,7 @@ const util = require(`${lib}/util`)
const normalize = require('../../support/normalize')

const packageVersion = '1.2.3'
const downloadDestination = path.join(os.tmpdir(), 'cypress.zip')
const downloadDestination = path.join(os.tmpdir(), `cypress-${process.pid}.zip`)
const installDir = '/cache/Cypress/1.2.3'

describe('/lib/tasks/install', function () {
Expand Down

4 comments on commit 09afc48

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 09afc48 Feb 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux x64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/6.6.0/circle-develop-09afc48e14f4b9c7268585327cf8b7358c8b78b1/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 09afc48 Feb 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AppVeyor has built the win32 x64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/6.5.0/appveyor-develop-09afc48e14f4b9c7268585327cf8b7358c8b78b1/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 09afc48 Feb 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AppVeyor has built the win32 ia32 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/6.5.0/appveyor-develop-09afc48e14f4b9c7268585327cf8b7358c8b78b1/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 09afc48 Feb 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin x64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/6.6.0/circle-develop-09afc48e14f4b9c7268585327cf8b7358c8b78b1/cypress.tgz

Please sign in to comment.