New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: updated styling for configuration files #23781
Conversation
…uld have the border
merging with develop
merging with develop
Thanks for taking the time to open a PR!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well, much more clear, Percy looks good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth capturing a new Percy screenshot in the test for Collapsible
to cover the true/false case on fileRow
? Or are the changes not going to be evident in Percy?
Per Ankit, Percy isn't quite sensitive enough to pick up the visual differences for the focus changes. Moving ahead without new snapshots |
Test summaryRun details
View run in Cypress Dashboard ➡️ FlakinessThis comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
User facing changelog
Additional details
Steps to test
How has the user experience changed?
Before:
After:
PR Tasks
cypress-documentation
?type definitions
?