Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updated styling for configuration files #23781

Merged
merged 8 commits into from Sep 12, 2022
Merged

chore: updated styling for configuration files #23781

merged 8 commits into from Sep 12, 2022

Conversation

amehta265
Copy link
Contributor

User facing changelog

Additional details

  • Why was this change necessary? So panels on different screens e.g. migration and configuration have similar styling for consistency.
  • FileRow.vue (Which renders the panels on the configuration) uses Collapsible.vue. Since Collapsible.vue is a reusable component that is leveraged by other components e.g. SettingCard, GeneratorSuccess e.t.c., adding any new styles to Collapsible for the purpose of re-designing FileRow would also adversely impact the other components that use Collapsible as unwanted styles would be applied to those components as well. In order to prevent this, I have added an optional prop in Collapsible, which when set to true would apply changes to the Collapsible component. The other components would not pass in this prop and therefore will not receive any unwanted styling changes.
  • In order for the header section of the panel be highlighted we need to independently control styles for the header and the bottom section of the panel. This is only possible by updating styles on Collapsible.vue.

Steps to test

  • No new tests have been added because only the UI/ styling for the configuration page has changed. All the functionality of the component has stayed the same.
  • However, in order to look at the updated UI, you can:
  1. Run yarn dev from the root folder (cypress)
  2. Add the launchpad as a project on the Cypress UI
  3. Go to e2e testing and run the project-setup.cy.ts spec file. Check the 'opens correctly in unconfigured project with --e2e' test to see the updated look of the config files.
  4. Change to Component Testing and run the FileRow.cy.ts spec file. Check the 'renders each status, the expected files, and expected styles' to see the updated look on different types of config files.

How has the user experience changed?

Before:
Screen Shot 2022-09-12 at 11 16 25 AM
After:
Screen Shot 2022-09-12 at 11 21 34 AM

PR Tasks

  • [na] Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 12, 2022

Thanks for taking the time to open a PR!

@amehta265 amehta265 requested a review from a team September 12, 2022 15:33
@marktnoonan marktnoonan self-requested a review September 12, 2022 19:31
Copy link
Contributor

@marktnoonan marktnoonan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, much more clear, Percy looks good 👍

Copy link
Contributor

@mike-plummer mike-plummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth capturing a new Percy screenshot in the test for Collapsible to cover the true/false case on fileRow? Or are the changes not going to be evident in Percy?

@astone123 astone123 self-requested a review September 12, 2022 20:06
@mike-plummer
Copy link
Contributor

Worth capturing a new Percy screenshot in the test for Collapsible to cover the true/false case on fileRow? Or are the changes not going to be evident in Percy?

Per Ankit, Percy isn't quite sensitive enough to pick up the visual differences for the focus changes. Moving ahead without new snapshots

@cypress
Copy link

cypress bot commented Sep 12, 2022



Test summary

40019 0 3346 0Flakiness 4


Run details

Project cypress
Status Passed
Commit 0264959
Started Sep 12, 2022 9:10 PM
Ended Sep 12, 2022 9:26 PM
Duration 15:51 💡
OS Linux Debian - 11.3
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

config_env.cy.ts Flakiness
1 cy.origin- Cypress.config() > serializable > overwrites different values in secondary, even if the Cypress.config() value does not exist in the primary
2 cy.origin- Cypress.config() > serializable > overwrites different values in secondary, even if the Cypress.config() value does not exist in the primary
commands/cookies.cy.ts Flakiness
1 cy.origin cookies > client side > .getCookie(), .getCookies(), and .setCookie()
commands/querying_shadow.cy.ts Flakiness
1 cy.origin shadow dom > .shadow()

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On focus, outline is only highlighting header on 'Rename existing specs' step
4 participants