Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On focus, outline is only highlighting header on 'Rename existing specs' step #21847

Closed
sync-by-unito bot opened this issue May 30, 2022 · 5 comments · Fixed by #23781
Closed

On focus, outline is only highlighting header on 'Rename existing specs' step #21847

sync-by-unito bot opened this issue May 30, 2022 · 5 comments · Fixed by #23781
Assignees
@amehta265
Labels
good first issue Good for newcomers type: bug

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented May 30, 2022 •
edited by jennifer-shehane

Current Behavior

Outline is only outlining header on ‘Rename existing specs’ step during migration, but for other parts of the UI, the outline is applied to the entire panel.

image (25)

image (27)

Desired Behavior

Have consistent outlining for each panel of the migration - outline the entire panel instead of just the header.

https://cypressio.slack.com/archives/C02MW5QBD4K/p1650558618050199

┆Issue is synchronized with this Jira Bug by Unito
┆Attachments: image (25).png | image (27).png
┆author: Zach Bloomquist
┆epic: UI/UX Improvements
┆friendlyId: UNIFY-1616
┆priority: Lowest
┆sprint: Backlog
┆taskType: Bug
@jennifer-shehane jennifer-shehane added the good first issue Good for newcomers label May 31, 2022
@keremh
Copy link

keremh commented Jul 13, 2022

hi @jennifer-shehane can i work on this issue?

@amehta265 amehta265 self-assigned this Sep 7, 2022
@amehta265
Copy link
Contributor

amehta265 commented Sep 7, 2022 •
edited

@mapsandapps I was wondering what the border requirements for each of the panel in migration are, based on the design specification?

@mapsandapps
Copy link
Contributor

@amehta265 according to both Figma and the design system components, only the header should have the border. If it makes sense to do now, please adjust the "configuration files" accordions to have that styling.

@amehta265 amehta265 mentioned this issue Sep 12, 2022
Merged
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review stage: review and removed stage: in progress stage: needs review The PR code is done & tested, needs review labels Sep 12, 2022
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 12, 2022

The code for this is done in cypress-io/cypress#23781, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 13, 2022

Released in 10.8.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.8.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Sep 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@amehta265 amehta265

Labels
good first issue Good for newcomers type: bug
Projects
None yet
Milestone
No milestone
4 participants
@jennifer-shehane @keremh @mapsandapps @amehta265