Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: On focus, outline is only highlighting header on 'Rename existing specs' step #23983

Closed
wants to merge 1 commit into from

Conversation

gitstart
Copy link
Contributor

@gitstart gitstart commented Sep 26, 2022

User-facing changelog

Fixed an issue where On focus, outline is only highlighting header on 'Rename existing specs' step

Steps to test

  • Run app on this current branch
  • Add a project with a lower version of cypress installed, to trigger the migration helper flow
  • Click on each migration steps
  • Verify that the box shadow is added around the complete container, and not just collapse header.

How has the user experience changed?

Before

pic

After

Screenshot from 2022-08-15 13-28-02

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 26, 2022

Thanks for taking the time to open a PR!

@gitstart gitstart marked this pull request as ready for review September 26, 2022 16:57
@astone123
Copy link
Contributor

We want to keep the existing behavior of only the header of the Collapsible component to be highlighted when focused. See this PR that closed the issue that this ticket is referencing for more information.

@astone123 astone123 closed this Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On focus, outline is only highlighting header on 'Rename existing specs' step
2 participants