Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip undefined steps in after scenario hooks #494

Merged
merged 2 commits into from Aug 16, 2022
Merged

Skip undefined steps in after scenario hooks #494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1d5a6b
Skip undefined steps in after scenario hooks
vearutop Aug 9, 2022
e158c25
Update CHANGELOG.md
vearutop Aug 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Expand Up @@ -14,6 +14,7 @@ This document is formatted according to the principles of [Keep A CHANGELOG](htt
### Fixed
- Fixed a bug which would ignore the context returned from a substep.([488](https://github.com/cucumber/godog/pull/488) - [wichert](https://github.com/wichert))
- Fixed a bug which would cause a panic when using the pretty formatter with a feature that contained a rule. ([480](https://github.com/cucumber/godog/pull/480) - [dumpsterfireproject](https://github.com/dumpsterfireproject))
- Multiple invocations of AfterScenario hooks in case of undefined steps. ([494](https://github.com/cucumber/godog/pull/494) - [vearutop](https://github.com/vearutop))

### Deprecated
- `godog` CLI tool prints deprecation warning. ([489](https://github.com/cucumber/godog/pull/489) - [vearutop](https://github.com/vearutop))
Expand Down
2 changes: 1 addition & 1 deletion suite.go
View file
Open in desktop
Expand Up @@ -99,7 +99,7 @@ func (s *suite) runStep(ctx context.Context, pickle *Scenario, step *Step, prevS
rctx, err = s.runAfterStepHooks(ctx, step, sr.Status, err)

// Trigger after scenario on failing or last step to attach possible hook error to step.
if sr.Status != StepSkipped && ((err == nil && isLast) || err != nil) {
if isLast || (sr.Status != StepSkipped && sr.Status != StepUndefined && err != nil) {
rctx, err = s.runAfterScenarioHooks(rctx, pickle, err)
}

Expand Down