Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip undefined steps in after scenario hooks #494

Merged
merged 2 commits into from Aug 16, 2022
Merged

Skip undefined steps in after scenario hooks #494

merged 2 commits into from Aug 16, 2022

Conversation

vearutop
Copy link
Member

@vearutop vearutop commented Aug 9, 2022

🤔 What's changed?

After scenario hooks will no be invoked after non-last undefined step.

⚡️ What's your motivation?

Originally, undefined steps that were in the middle of scenario would invoke s.runAfterScenarioHooks and then proceed to next steps. This may result in multiple invocations of after scenario hooks which is incorrect behavior.

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #494 (e158c25) into main (fd5b6a1) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #494   +/-   ##
=======================================
  Coverage   81.69%   81.69%           
=======================================
  Files          27       27           
  Lines        2267     2267           
=======================================
  Hits         1852     1852           
  Misses        316      316           
  Partials       99       99           
Impacted Files Coverage Δ
suite.go 87.61% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

github-actions bot commented Aug 9, 2022

Go API Changes

# github.com/cucumber/godog
## compatible changes
Feature: added

# summary
Inferred base version: v0.12.5
Suggested version: v0.13.0

@vearutop vearutop requested a review from nhatthm August 15, 2022 23:47
@vearutop vearutop merged commit 2028828 into main Aug 16, 2022
@vearutop vearutop deleted the skip-undef branch August 16, 2022 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants