New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rails 5.2 & Capybara 3 support. #378
Changes from 7 commits
416c543
3bbb2a2
238c391
6100eb4
10084a9
685413c
dc6a590
937d44c
1ef3b51
0775efb
8362a27
a6b99ea
bd504a6
4cd9f63
3b88c6b
e942fd1
4502e05
8b47a03
cfcd0ea
286f37f
f11ad2d
6f83768
c1a6626
32ba8db
8300612
4763fde
8fb4040
1a85e85
dee9b75
eab831a
9731f9b
c480e62
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,7 @@ $LOAD_PATH.unshift File.expand_path("../lib", __FILE__) | |
|
||
Gem::Specification.new do |s| | ||
s.name = 'cucumber-rails' | ||
s.version = '1.5.0' | ||
s.version = '1.6.0' | ||
s.authors = ["Aslak Hellesøy", "Dennis Blöte", "Rob Holland"] | ||
s.description = "Cucumber Generator and Runtime for Rails" | ||
s.summary = "#{s.name}-#{s.version}" | ||
|
@@ -12,23 +12,23 @@ Gem::Specification.new do |s| | |
|
||
s.license = 'MIT' | ||
|
||
s.add_runtime_dependency('capybara', ['>= 1.1.2', '< 3']) | ||
s.add_runtime_dependency('capybara', ['>= 1.1.2', '< 4']) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This also resolves @Kosmas' request here: #375 (comment) 👍 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
s.add_runtime_dependency('cucumber', ['>= 3.0.2', '< 4']) | ||
s.add_runtime_dependency('nokogiri', '~> 1.5') | ||
s.add_runtime_dependency('railties', ['>= 4', '< 5.2']) | ||
s.add_runtime_dependency('nokogiri', '~> 1.8') | ||
s.add_runtime_dependency('railties', ['>= 4', '< 6']) | ||
s.add_runtime_dependency('mime-types', ['>= 1.17', '< 4']) | ||
|
||
# Main development dependencies | ||
s.add_development_dependency('ammeter', ['>= 1.0.0', '!= 1.1.3']) | ||
s.add_development_dependency('appraisal', '>= 0.5.1') | ||
s.add_development_dependency('aruba', '~> 0.14.2') | ||
s.add_development_dependency('aruba', '>= 0.14.2') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The latest release of aruba is in the 0.14.x series, so this change has no effect currently. |
||
s.add_development_dependency('builder', ['>= 3.1.0', '< 4']) | ||
s.add_development_dependency('bundler', '>= 1.3.5') | ||
s.add_development_dependency('selenium-webdriver', '>= 3.4.1') | ||
s.add_development_dependency('database_cleaner', '>= 1.0.0') | ||
s.add_development_dependency('factory_girl', '>= 3.2') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Consider changing this to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I've just submitted a PR to your repo for this: gobijan#2 |
||
s.add_development_dependency('rake', '>= 0.9.2.2') | ||
s.add_development_dependency('rspec', '~> 3.0') | ||
s.add_development_dependency('rspec', '~> 3') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This will allow RSpec 4, which is probably not what you want. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should become There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Woops. I'll fix that now - thanks @mvz! |
||
s.add_development_dependency('rails') | ||
s.add_development_dependency('sqlite3') | ||
|
||
|
@@ -37,7 +37,7 @@ Gem::Specification.new do |s| | |
s.add_development_dependency('rdoc', '>= 3.4') | ||
s.add_development_dependency('yard', '>= 0.8.7') | ||
|
||
s.required_ruby_version = '>= 2.2.0' | ||
s.required_ruby_version = '>= 2.3.0' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
s.rubygems_version = ">= 1.6.1" | ||
s.files = `git ls-files`.split("\n") | ||
s.test_files = `git ls-files -- {spec,features}/*`.split("\n") | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
# This file was generated by Appraisal | ||
|
||
source "https://rubygems.org" | ||
|
||
gem "rails", "~> 5.2" | ||
gem "railties", "~> 5.2" | ||
gem "capybara", "~> 3.0" | ||
gem "selenium-webdriver", "~> 3.11" | ||
gem "geckodriver-helper", "~> 0.0.4" | ||
gem "rspec-rails", "~> 3.7" | ||
gem "sass-rails", "~> 5.0" | ||
gem "coffee-rails", "~> 4.2" | ||
gem "uglifier", "~> 4.1" | ||
gem "sqlite3", "~> 1.3.13" | ||
gem "database_cleaner", ">= 1.6.2" | ||
|
||
gemspec path: "../" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest keeping this, as cucumber-rails still is using Ruby 2.2. If Rails 5.2 requires higher, then I suggest excluding it below in
.travis.yml
.