Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rails 5.2 & Capybara 3 support. #378

Merged
merged 32 commits into from Apr 20, 2018
Merged

Commits on Apr 12, 2018

  1. Copy the full SHA
    416c543 View commit details
    Browse the repository at this point in the history
  2. Add gemfile for rails 5.2.

    gobijan committed Apr 12, 2018
    Copy the full SHA
    3bbb2a2 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    238c391 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    6100eb4 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    10084a9 View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    685413c View commit details
    Browse the repository at this point in the history
  7. Add rails 5.2 to appraisals.

    gobijan committed Apr 12, 2018
    Copy the full SHA
    dc6a590 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2018

  1. Bump geckodriver-helper version to 0.0.5

    Ryan Bigg committed Apr 17, 2018
    Copy the full SHA
    937d44c View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2018

  1. Copy the full SHA
    1ef3b51 View commit details
    Browse the repository at this point in the history
  2. Add gemfile for rails 5.2.

    gobijan committed Apr 18, 2018
    Copy the full SHA
    0775efb View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    8362a27 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    a6b99ea View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    bd504a6 View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    4cd9f63 View commit details
    Browse the repository at this point in the history
  7. Add rails 5.2 to appraisals.

    gobijan committed Apr 18, 2018
    Copy the full SHA
    3b88c6b View commit details
    Browse the repository at this point in the history
  8. factory_girl -> factory_bot

    Ryan Bigg authored and gobijan committed Apr 18, 2018
    Copy the full SHA
    e942fd1 View commit details
    Browse the repository at this point in the history
  9. Fix other occurrences of factory_girl

    Ryan Bigg authored and gobijan committed Apr 18, 2018
    Copy the full SHA
    4502e05 View commit details
    Browse the repository at this point in the history
  10. Copy the full SHA
    8b47a03 View commit details
    Browse the repository at this point in the history
  11. Merge pull request #1 from radar/master

    Bump geckodriver-helper version to 0.0.5
    gobijan committed Apr 18, 2018
    Copy the full SHA
    cfcd0ea View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2018

  1. Make click_with_javascript_emulation take any args

    During the "Delete Widgets" test, this happens:
    
        When I follow "Destroy"                 # features/step_definitions/web_steps.rb:48
          wrong number of arguments (given 2, expected 0) (ArgumentError)
          /Users/ryanbigg/code/gems/cucumber-rails/lib/cucumber/rails/capybara/javascript_emulation.rb:12:in `click_with_javascript_emulation'
          /usr/local/Cellar/asdf/0.4.1/installs/ruby/2.4.4/lib/ruby/gems/2.4.0/gems/capybara-3.0.2/lib/capybara/node/element.rb:133:in `block in click'
          /usr/local/Cellar/asdf/0.4.1/installs/ruby/2.4.4/lib/ruby/gems/2.4.0/gems/capybara-3.0.2/lib/capybara/node/base.rb:83:in `synchronize'
          /usr/local/Cellar/asdf/0.4.1/installs/ruby/2.4.4/lib/ruby/gems/2.4.0/gems/capybara-3.0.2/lib/capybara/node/element.rb:133:in `click'
          /usr/local/Cellar/asdf/0.4.1/installs/ruby/2.4.4/lib/ruby/gems/2.4.0/gems/capybara-3.0.2/lib/capybara/node/actions.rb:41:in `click_link'
          /usr/local/Cellar/asdf/0.4.1/installs/ruby/2.4.4/lib/ruby/gems/2.4.0/gems/capybara-3.0.2/lib/capybara/session.rb:740:in `block (2 levels) in <class:Session>'
          /usr/local/Cellar/asdf/0.4.1/installs/ruby/2.4.4/lib/ruby/gems/2.4.0/gems/capybara-3.0.2/lib/capybara/dsl.rb:51:in `block (2 levels) in <module:DSL>'
          /Users/ryanbigg/code/gems/cucumber-rails/tmp/aruba/test_app/features/step_definitions/web_steps.rb:49:in `block in <main>'
    
      This is because Capybara 3 now passes two additional arguments to
      Cucumber's method. But this Cucumber method needs to do nothing with
      those arguments other than accept them.
    
      This will make the "Deleting a widget" test pass once again.
    Ryan Bigg committed Apr 19, 2018
    Copy the full SHA
    286f37f View commit details
    Browse the repository at this point in the history
  2. install the latest version of firefox

    Ryan Bigg committed Apr 19, 2018
    Copy the full SHA
    f11ad2d View commit details
    Browse the repository at this point in the history
  3. Report geckodriver version before running tests

    Ryan Bigg committed Apr 19, 2018
    Copy the full SHA
    6f83768 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    c1a6626 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2018

  1. Merge pull request #6 from xtrasimplicity/BugFix/FixingBootsnapIssues

    Fixed bootsnap issues on Rails 5.2
    gobijan committed Apr 20, 2018
    Copy the full SHA
    32ba8db View commit details
    Browse the repository at this point in the history
  2. Merge pull request #5 from radar/use-latest-firefox

    Use latest firefox
    gobijan committed Apr 20, 2018
    Copy the full SHA
    8300612 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #4 from radar/click-with-js-emulation-args

    Make click_with_javascript_emulation take any args
    gobijan committed Apr 20, 2018
    Copy the full SHA
    4763fde View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    8fb4040 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    1a85e85 View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    dee9b75 View commit details
    Browse the repository at this point in the history
  7. Copy the full SHA
    eab831a View commit details
    Browse the repository at this point in the history
  8. Copy the full SHA
    9731f9b View commit details
    Browse the repository at this point in the history
  9. Fixed RSpec versioning

    xtrasimplicity committed Apr 20, 2018
    Copy the full SHA
    c480e62 View commit details
    Browse the repository at this point in the history