Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ruby 3.3 to CI matrix - Drop Travis gem, ruby_dep gem, files gem #1007

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Add Ruby 3.3 to CI matrix - Drop Travis gem, ruby_dep gem, files gem #1007

wants to merge 3 commits into from

Conversation

olleolleolle
Copy link
Contributor

@olleolleolle olleolleolle commented Feb 8, 2024 •
edited

This made the test suite pass on Ruby 3.3. 馃煝

  • Drop unused Travis gem
  • Drop ruby_dep gem
  • Drop files gem and work around it using Pathname
  • Told RuboCop to ignore one file, in order that it would be able to run on all the others. Perhaps this RuboCop version's old, or something. In any case, it's better that it can run.

@olleolleolle
Drop Travis gem, ruby_dep gem, files gem
2a4c51a 
This made the test suite pass on Ruby 3.3.
@olleolleolle
CI: Add Ruby 3.3
2003c08
@olleolleolle
RuboCop: exclude Guardfile from list of files
17ad90f 
This version of RuboCop failed to execute when reading that file, with
this error:

An error occurred while Layout/BlockAlignment cop was inspecting
/home/runner/work/annotate_models/annotate_models/Guardfile:9:0.

So, ignoring that, for now.
@olleolleolle olleolleolle changed the title Drop Travis gem, ruby_dep gem, files gem Add Ruby 3.3 to CI matrix - Drop Travis gem, ruby_dep gem, files gem Feb 8, 2024
@olleolleolle olleolleolle mentioned this pull request Feb 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@olleolleolle