Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add COMMENT support to indexes #1006

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat: add COMMENT support to indexes #1006

wants to merge 1 commit into from

Conversation

olleolleolle
Copy link
Contributor

@olleolleolle olleolleolle commented Feb 8, 2024 •
edited

This reads out any COMMENT added to an INDEX object and adds its after the last output on its "details" line.

An example of what this looks like:

 # Indexes
 #
-#  attestations_avoid_same_employee  (attested_by_employee_id,subject_id,subject_type) UNIQUE
+#  attestations_avoid_same_employee  (attested_by_employee_id,subject_id,subject_type) UNIQUE COMMENT My explanatory comment is right here

EDIT: I added a test case after I had made it possible to run them locally on newer Ruby versions, in #1007

@olleolleolle olleolleolle force-pushed the add-comment-on-index branch 2 times, most recently from 30e1901 to 1f84ed8 Compare February 9, 2024 08:46
@olleolleolle
feat: add COMMENT support to indexes
1b625fb 
This reads out any COMMENT added to an INDEX object and adds its after
the last output on its "details" line.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@olleolleolle