Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(openshift): configurable resource mapping from properties #662

Merged

Conversation

andrewazores
Copy link
Member

Fixes #635

@andrewazores andrewazores force-pushed the configurable-resource-mapping branch from a610fbb to 7b3dafb Compare May 31, 2022 01:17
@andrewazores andrewazores marked this pull request as ready for review May 31, 2022 01:18
@andrewazores andrewazores requested a review from ebaron May 31, 2022 01:18
@andrewazores
Copy link
Member Author

@ebaron I haven't exercised this in an actual OpenShift/k8s environment in a while, but I just finished rebasing this and getting it back into shape. Let me know what you think and if this is a good step toward the better Kubernetes RBAC stuff we need. The configuration is done in the file src/main/java/io/cryostat/net/openshift/OpenShiftAuthManager.properties. For now it just maps the Cryostat application-level resource RECORDING to k8s operator.cryostat.io/recordings (the Recordings CRD), and the CERTIFICATE to k8s apps/deployments,pods.

Copy link
Member

@ebaron ebaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Andrew, seems good overall. One comment about the property file syntax.

Copy link
Member

@ebaron ebaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well!

@andrewazores andrewazores merged commit d95f1f9 into cryostatio:main Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Fine-tune Kubernetes/OpenShift RBAC permissions
2 participants