-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(openshift): configurable resource mapping from properties #662
feat(openshift): configurable resource mapping from properties #662
Conversation
f3f5b0e
to
08b92fa
Compare
a610fbb
to
7b3dafb
Compare
@ebaron I haven't exercised this in an actual OpenShift/k8s environment in a while, but I just finished rebasing this and getting it back into shape. Let me know what you think and if this is a good step toward the better Kubernetes RBAC stuff we need. The configuration is done in the file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Andrew, seems good overall. One comment about the property file syntax.
src/main/resources/io/cryostat/net/openshift/OpenShiftAuthManager.properties
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well!
Fixes #635