Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API support for uploading client libraries #485

Closed
andrewazores opened this issue May 26, 2021 · 2 comments
Closed

Add API support for uploading client libraries #485

andrewazores opened this issue May 26, 2021 · 2 comments
Labels
feat New feature or request question Further information is requested

Comments

@andrewazores
Copy link
Member

#482 (comment)

Should there be an API to allow clients to upload ex. jboss-client.jar to Cryostat's storage in a place that is added to the Cryostat classpath, so that end users can extend their Cryostat deployment to support other protocols than rmi?

@andrewazores andrewazores added enhancement question Further information is requested labels May 26, 2021
@ebaron
Copy link
Member

ebaron commented May 26, 2021

I feel like this could be risky from a security perspective. This may be better suited for the operator, or have the user manually edit the Cryostat deployment. For example, the authenticated Cryostat user may have permission to read objects in the namespace, but not to modify the Cryostat deployment. So there could be some potential for privilege escalation there.

@andrewazores andrewazores added feat New feature or request and removed enhancement labels Sep 1, 2021
@andrewazores andrewazores reopened this Sep 10, 2021
@andrewazores
Copy link
Member Author

andrewazores commented Sep 10, 2021

Since #599 , maybe we can support this now. Maybe in conjunction with #662 , although that means it may miss 2.0.0. Still, it seems like we should be able to create this upload handler which allows adding libraries but only if the user has an UPDATE_CRYOSTAT permission, which we can map to patch cryostats or similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants