Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Make all off-site links open in a new tab #563

Closed
crweiner opened this issue Oct 1, 2022 · 5 comments · Fixed by #577
Closed

Feature: Make all off-site links open in a new tab #563

crweiner opened this issue Oct 1, 2022 · 5 comments · Fixed by #577
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Contributed in the spirit of Hacktoberfest! help wanted Extra attention is needed

Comments

@crweiner
Copy link
Owner

crweiner commented Oct 1, 2022

MkDocs and the Material theme have support for Python Markdown. To get off-site links to open in a new tab, instead of inline at HacktoberfestSwagList.com, they must be given the target="_blank" attribute.

Please enable the Attribute Lists extension so that this can then be added to each off-site link.

This PR and this PR and this PR will lead you down the right path. 😄

@crweiner crweiner added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest Contributed in the spirit of Hacktoberfest! labels Oct 1, 2022
@rrsingh11
Copy link

Hello, Can you please assign this issue to me?

@donheshanthaka
Copy link

Hey there, can i work on this too

@asi309
Copy link
Contributor

asi309 commented Oct 1, 2022

#573 Enables Attributes List extension

@crweiner
Copy link
Owner Author

crweiner commented Oct 1, 2022

Hello all! I don't assign issues, as I have seen that more often than not, people tend to disappear once assigned.

This Issue has not yet been fully resolved, and I welcome additional PRs!

@crweiner
Copy link
Owner Author

crweiner commented Oct 1, 2022

Featured added in #573, but all of the links still need to be updated across the Swag List.

Additionally, the Contributing.md doc should be updated with the reference too. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Contributed in the spirit of Hacktoberfest! help wanted Extra attention is needed
Projects
None yet
4 participants