Make all off-site links open in a new tab #577
Conversation
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| 1. Be sure you are looking to add something of substance to this project, not just spam PRs. PRs must meet the [Hacktoberfest Quality Standards](https://hacktoberfest.com/participation/). | ||
| 2. Verify that you have read the [home page](index.md), and [Readme.md on GitHub](https://github.com/crweiner/hacktoberfest-swag-list/blob/master/README.md). You understand that this project is to connect maintainers with developers, not a way to get all the swag you can. | ||
| 1. Be sure you are looking to add something of substance to this project, not just spam PRs. PRs must meet the [Hacktoberfest Quality Standards](https://hacktoberfest.com/participation/){:target="\_blank"}. | ||
| 2. Verify that you have read the [home page](index.md), and [Readme.md on GitHub](https://github.com/crweiner/hacktoberfest-swag-list/blob/master/README.md){:target="\_blank"}. You understand that this project is to connect maintainers with developers, not a way to get all the swag you can. |
Update mkdocs.yml enables Attributes List
👇 Click on the image for a new way to code review
Legend |
✅ Deploy Preview for hacktoberfest-swag-list ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Sorry for throwing a monkey wrench in some of your plans here, @letsintegreat. 😅 I've merged some PRs so the list is updated. Would you able to update your fork and/or rebase? I really like how you went through and made sure each link opens in a new tab, which I would like to get merged! |
|
@crweiner |
|
@crweiner There you have it! |
|
Code Climate has analyzed commit 65f2b03 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
Another beautiful job, thank you again @letsintegreat! This was very helpful, now people can stay on the Swag List and still check out the organizations. I appreciate it! 🎉 |
|
@crweiner Umm, for some reasons your repository has been excluded from hacktoberfest. I am not sure why.
Do you know anything about it? |
|
Thanks for the heads up, I'll reach out to the Hacktoberfest folks to see. 👍 |
|
@crweiner Alright, looking forward to hearing about any updates. |
|
Hey @letsintegreat can you please take another look? I reached out to the Hacktoberfest team and they let me know they lifted the exclusion. 😺 |
|
@crweiner Neat! Excluded status has been removed from your repo. Thanks :D |
Thanks for contributing to the Hacktoberfest Swag List 😃 🎉! Before submitting your pull request, please check off as many of the items below as you can:
Thanks and Happy Hacktoberfest! 🎉
Tagging @crweiner to take a look. 👀
Closes #563