Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all off-site links open in a new tab #574

Closed

Conversation

donheshanthaka
Copy link

Fixes: #563

Thanks for contributing to the Hacktoberfest Swag List 😃 🎉! Before submitting your pull request, please check off as many of the items below as you can:

  1. I have read the Contributing.md file and formatted this PR correctly
  2. I'm not adding a company from the blocklist
  3. I make sure to fix things promptly if an error or suggestion comes up

Thanks and Happy Hacktoberfest! 🎉
Tagging @crweiner to take a look. 👀

@codeclimate
Copy link

codeclimate bot commented Oct 1, 2022

Code Climate has analyzed commit 0d675b8 and detected 0 issues on this pull request.

View more on Code Climate.

@netlify
Copy link

netlify bot commented Oct 1, 2022

Deploy Preview for hacktoberfest-swag-list ready!

Name Link
🔨 Latest commit 0d675b8
🔍 Latest deploy log https://app.netlify.com/sites/hacktoberfest-swag-list/deploys/63383ed9b2f9d90009c82cab
😎 Deploy Preview https://deploy-preview-574--hacktoberfest-swag-list.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ghost
Copy link

ghost commented Oct 1, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@crweiner
Copy link
Owner

crweiner commented Oct 1, 2022

Hello @donheshanthaka! Thank you for your PR to update the off-site links to open in a new tab!

It appears like you're using an old version of the Swag List; the one from the end of 2021. Can you please rebase or submit a new PR with this fix applied to the current MkDocs version of the Swag List? Thank you!

@crweiner
Copy link
Owner

crweiner commented Oct 1, 2022

This has now been added in PR #573

@crweiner crweiner closed this Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Make all off-site links open in a new tab
2 participants