Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Add CVE-2019-5477 the to travis ignore list (SOC-9635) #1911

Merged
merged 1 commit into from Aug 30, 2019

Commits on Aug 30, 2019

  1. Add CVE-2019-5477 the to travis ignore list (SOC-9635)

    A bunch of PRs in the crowbar-core are blocked due to a travis CI check:
    
      bundle-audit check --ignore ...
    
    This is due to a security embargo that was lifted and blocked by a
    version of nokogiri:
    
      Name: nokogiri
      Version: 1.9.1
      Advisory: CVE-2019-5477
      Criticality: Unknown
      URL: sparklemotion/nokogiri#1915
      Title: Nokogiri Command Injection Vulnerability via
             Nokogiri::CSS::Tokenizer#load_file
      Solution: upgrade to >= 1.10.4
    
    I asked about it in the rocketchat #cloud channel, and apparently Rick
    has looked into it and it seems we are unaffected by it as we don't use
    the version when building the RPM.
    
    I've also done a quick look through IBS and I can't see nokogiri as a
    build requirement for crowbar, crowbar-core or crowbar-openstack. Well
    it isn't even mentioned in any of the spec files.
    
    So raising this PR to add it to the ignore so we can unblock the
    crowbar-core PRs.
    
    Adding the SOC-9635, as its the patch of mine that is blocked on it, and
    so it passes travis CI.
    
    (cherry picked from commit 8400e28)
    matthewoliver authored and rhafer committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    d0fc176 View commit details
    Browse the repository at this point in the history