[4.0] Add CVE-2019-5477 the to travis ignore list (SOC-9635) #1911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bunch of PRs in the crowbar-core are blocked due to a travis CI check: bundle-audit check --ignore ... This is due to a security embargo that was lifted and blocked by a version of nokogiri: Name: nokogiri Version: 1.9.1 Advisory: CVE-2019-5477 Criticality: Unknown URL: sparklemotion/nokogiri#1915 Title: Nokogiri Command Injection Vulnerability via Nokogiri::CSS::Tokenizer#load_file Solution: upgrade to >= 1.10.4 I asked about it in the rocketchat #cloud channel, and apparently Rick has looked into it and it seems we are unaffected by it as we don't use the version when building the RPM. I've also done a quick look through IBS and I can't see nokogiri as a build requirement for crowbar, crowbar-core or crowbar-openstack. Well it isn't even mentioned in any of the spec files. So raising this PR to add it to the ignore so we can unblock the crowbar-core PRs. Adding the SOC-9635, as its the patch of mine that is blocked on it, and so it passes travis CI. (cherry picked from commit 8400e28)
rhafer
changed the title
dirkmueller
approved these changes
Aug 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of PRs in the crowbar-core are blocked due to a travis CI check:
bundle-audit check --ignore ...
This is due to a security embargo that was lifted and blocked by a
version of nokogiri:
Name: nokogiri
Version: 1.9.1
Advisory: CVE-2019-5477
Criticality: Unknown
URL: sparklemotion/nokogiri#1915
Title: Nokogiri Command Injection Vulnerability via
Nokogiri::CSS::Tokenizer#load_file
Solution: upgrade to >= 1.10.4
I asked about it in the rocketchat #cloud channel, and apparently Rick
has looked into it and it seems we are unaffected by it as we don't use
the version when building the RPM.
I've also done a quick look through IBS and I can't see nokogiri as a
build requirement for crowbar, crowbar-core or crowbar-openstack. Well
it isn't even mentioned in any of the spec files.
So raising this PR to add it to the ignore so we can unblock the
crowbar-core PRs.
Adding the SOC-9635, as its the patch of mine that is blocked on it, and
so it passes travis CI.
(cherry picked from commit 8400e28)