Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump go version to build kubernetes #2955

Merged
merged 4 commits into from Nov 7, 2019
Merged

bump go version to build kubernetes #2955

merged 4 commits into from Nov 7, 2019

Conversation

haircommander
Copy link
Member

Signed-off-by: Peter Hunt pehunt@redhat.com

@haircommander
bump go version to build kubernetes
4d6cac6 
Signed-off-by: Peter Hunt <pehunt@redhat.com>
@openshift-ci-robot openshift-ci-robot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Nov 7, 2019
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 7, 2019
@haircommander
Copy link
Member Author

another day, another set of CI flakes 😃

@haircommander
drop godoc
eebeefb 
As it's not included in go installation anymore, and I don't think it's needed anyway

Signed-off-by: Peter Hunt <pehunt@redhat.com>
@codecov
Copy link

codecov bot commented Nov 7, 2019

Codecov Report

Merging #2955 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2955   +/-   ##
=======================================
  Coverage   52.45%   52.45%           
=======================================
  Files          88       88           
  Lines        7145     7145           
=======================================
  Hits         3748     3748           
  Misses       3015     3015           
  Partials      382      382

@haircommander
Copy link
Member Author

cri-tools is running into golangci/golangci-lint#659 because it uses v1.17.1. Opening a PR now...

saschagrunert
saschagrunert approved these changes Nov 7, 2019
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2019
@haircommander
Copy link
Member Author

critest* and integration* need kubernetes-sigs/cri-tools#552

@haircommander haircommander mentioned this pull request Nov 7, 2019
Merged
@haircommander
Use updated cri-tools
23680d6 
that includes fixes for a compile error with golangci-lint, and also builds with go 1.13.

Signed-off-by: Peter Hunt <pehunt@redhat.com>
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 7, 2019
@haircommander
Copy link
Member Author

I also added a temp cri-tools bump until the 1.13 changes are released. this should get tests to pass.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 7, 2019
@haircommander haircommander force-pushed the go-1.13.4 branch 2 times, most recently from d1a64a7 to 4e85ef7 Compare November 7, 2019 19:58
@haircommander
don't use go install to install cri-tools
8a45293 
Signed-off-by: Peter Hunt <pehunt@redhat.com>
@haircommander
Copy link
Member Author

finally
@mrunalp @umohnani8 @saschagrunert PTAL

@haircommander
Copy link
Member Author

/retest

2 similar comments
@haircommander
Copy link
Member Author

/retest

@haircommander
Copy link
Member Author

/retest

@haircommander
Copy link
Member Author

/retest

1 similar comment
@haircommander
Copy link
Member Author

/retest

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, mrunalp, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mrunalp,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, mrunalp, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mrunalp,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mrunalp
Copy link
Member

mrunalp commented Nov 7, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2019
@openshift-merge-robot openshift-merge-robot merged commit 55b35f7 into cri-o:master Nov 7, 2019
@openshift-ci-robot openshift-ci-robot mentioned this pull request Dec 3, 2019
Closed
@haircommander haircommander deleted the go-1.13.4 branch September 27, 2021 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@runcom runcom Awaiting requested review from runcom

@giuseppe giuseppe Awaiting requested review from giuseppe

@sameo sameo Awaiting requested review from sameo

@vrothberg vrothberg Awaiting requested review from vrothberg

Assignees

@mrunalp mrunalp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@haircommander @openshift-ci-robot @mrunalp @saschagrunert @openshift-merge-robot