run e2e tests using crun

[giuseppe]

Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [giuseppe]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Merging #2943 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2943   +/-   ##
=======================================
  Coverage   47.08%   47.08%           
=======================================
  Files          88       88           
  Lines        7155     7155           
=======================================
  Hits         3369     3369           
  Misses       3496     3496           
  Partials      290      290

[giuseppe]

@rhatdan @mrunalp tests pass on Fedora.

Failures on RHEL are expected as there are missing build dependencies

[giuseppe]

I've pushed another version where crun installation can be configured.

crun tests won't run until openshift-eng/aos-cd-jobs#2027 is not merged

[haircommander]

(this will need #2955 to be in before any jenkins tests will pass BTW)

[haircommander]

LGTM @giuseppe can WIP be removed?

[giuseppe]

@mrunalp @haircommander PTAL

[rhatdan]

LGTM, but you still had one test fail.
Removed the WIP.

[haircommander]

Am i correct in thinking there aren't any tests running with crun yet? This seems to lay the skeleton

[TomSweeneyRedHat]

LGTM assuming happy tests

[rhatdan]

@haircommander Yup that is the idea. The real goal is to get to the point we can run on cgroup V2 if kubernetes patches get in, prior to runc getting support.

[haircommander]

I've triggered the tests again. integration-static-glibc failed twice on the same test, but there are no clear changes here that could cause it (it was in network.bats). I'm hoping some sun spot flips a bit and it goes green

[giuseppe]

in a previous version I manually forced to run with crun and the e2e tests passed. So I've changed it back to be configurable and we need: openshift-eng/aos-cd-jobs#2027 to run both crun and runc tests

[haircommander]

finally happy tests
/lgtm

[saschagrunert]

/retest

[giuseppe]

/cherrypick release-1.15

[openshift-cherrypick-robot]

@giuseppe: #2943 failed to apply on top of branch "release-1.15":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	test/ctr.bats
Falling back to patching base and 3-way merge...
Auto-merging test/ctr.bats
CONFLICT (content): Merge conflict in test/ctr.bats
Patch failed at 0001 tests: adjust test to not depend on runc behavior

In response to this:

/cherrypick release-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@giuseppe: #2943 failed to apply on top of branch "release-1.15":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	test/ctr.bats
Falling back to patching base and 3-way merge...
Auto-merging test/ctr.bats
CONFLICT (content): Merge conflict in test/ctr.bats
Patch failed at 0001 tests: adjust test to not depend on runc behavior

In response to this:

/cherrypick release-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.