Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Upgrade puppeteer #1851

Merged
merged 2 commits into from Jul 13, 2021
Merged

fix: Upgrade puppeteer #1851

merged 2 commits into from Jul 13, 2021

Commits on Jul 12, 2021

  1. fix: Upgrade puppeteer 

    Previous version used to randomly hang while creating screenshots

This issues shows that some old versions are subjective to random
freezes puppeteer/puppeteer#4011

So upgrading to latest version should fix our issue

This fixes #1842
    @Ldoppea
    Ldoppea committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    a8b8aa0 View commit details
    Browse the repository at this point in the history

  2. fix: Generates screenshots with captureBeyondViewport disabled 

    Puppeteer V7 introduced a breaking change on how ViewPort is handled.

Since this change, page.screenshot() now captures using Clip dimensions
instead of ViewPort size

To come back to old behavior `captureBeyondViewport` should be set to
`false`

See: https://github.com/puppeteer/puppeteer/releases/tag/v7.0.0
    @Ldoppea
    Ldoppea committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    48d1178 View commit details
    Browse the repository at this point in the history