fix: Upgrade puppeteer #1851
Merged
fix: Upgrade puppeteer #1851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous version used to randomly hang while creating screenshots This issues shows that some old versions are subjective to random freezes puppeteer/puppeteer#4011 So upgrading to latest version should fix our issue This fixes #1842
Puppeteer V7 introduced a breaking change on how ViewPort is handled. Since this change, page.screenshot() now captures using Clip dimensions instead of ViewPort size To come back to old behavior `captureBeyondViewport` should be set to `false` See: https://github.com/puppeteer/puppeteer/releases/tag/v7.0.0
Merkur39
approved these changes
Jul 13, 2021
|
Awesome! Thanks you so much for the effort ! |
cozy-bot
pushed a commit
that referenced
this pull request
Jul 13, 2021
generated from commit 85dd56c
|
🎉 This PR is included in version 51.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous version used to randomly hang while creating screenshots
This issues shows that some old versions are subjective to random
freezes puppeteer/puppeteer#4011
So upgrading to latest version should fix our issue
This fixes #1842
If your changes have graphic impacts, it is useful to deploy a version
of the styleguidist to your repository.