Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove cosmossdk.io/x/* dependence in the root go module #18290

Closed
4 tasks
Tracked by #11899
tac0turtle opened this issue Oct 28, 2023 · 4 comments · May be fixed by #20066
Closed
4 tasks
Tracked by #11899

remove cosmossdk.io/x/* dependence in the root go module #18290

tac0turtle opened this issue Oct 28, 2023 · 4 comments · May be fixed by #20066
Assignees
@tac0turtle @hieuvubk
Labels
dependencies Pull requests that update a dependency file T: Tests

Comments

@tac0turtle
Copy link
Member

tac0turtle commented Oct 28, 2023 •
edited

While spinning out modules from the cosmos sdk go.mod we introduced module imports into the cosmos sdk. We need to remove these.

  • Baseapp
  • Client (marko)
  • Server
  • Testutils
@tac0turtle tac0turtle mentioned this issue Oct 28, 2023
Closed
81 tasks
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Oct 28, 2023
@tac0turtle tac0turtle changed the title cleanup all module imports in cosmos-sdk remove cosmossdk.io/x/* dependence in the root go module Oct 28, 2023
@tac0turtle tac0turtle added T: Tests dependencies Pull requests that update a dependency file T:Sprint and removed needs-triage Issue that needs to be triaged labels Oct 28, 2023
@tac0turtle tac0turtle mentioned this issue Oct 30, 2023
Merged
20 tasks
@odeke-em odeke-em self-assigned this Oct 30, 2023
@tac0turtle tac0turtle mentioned this issue Oct 30, 2023
Merged
20 tasks
This was referenced Nov 6, 2023
Closed
Closed
Closed
@odeke-em
Copy link
Collaborator

odeke-em commented Nov 8, 2023 •
edited

Perhaps we should think about spinning out the Go module for "cosmossdk.io/testutil" because in the root go.mod, the reason why we need a bunch of those modules added to the top level is because testutil/network uses them, it doesn't have a go.mod file and can't use a replace directive and guess what? Almost every module imports "github.com/cosmos/cosmos-sdk/testuti/*" per this command

$ git grep 'github.com/cosmos/cosmos-sdk/testutil' | cut -d":" -f1 | xargs dirname | sort | uniq

and that currently returns unique 148 directories that import it

@tac0turtle
Copy link
Member Author

i dont think we should move the entire thing but parts of it, we will handle this issue

@julienrbrt julienrbrt mentioned this issue Nov 9, 2023
Merged
20 tasks
@julienrbrt julienrbrt mentioned this issue Nov 22, 2023
Merged
20 tasks
This was referenced Jan 24, 2024
Closed
Merged
@tac0turtle
Copy link
Member Author

i think testutils is the only worry here. since baseapp client and server will be deleted this year

This was referenced Apr 17, 2024
Draft
Closed
This was referenced May 3, 2024
Merged
Merged
@tac0turtle
Copy link
Member Author

closing this in favour of #20279

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tac0turtle tac0turtle

@hieuvubk hieuvubk

Labels
dependencies Pull requests that update a dependency file T: Tests
Projects
Cosmos-SDK
Status: 🥳 Done
Milestone
No milestone
7 participants
@odeke-em @tac0turtle @julienrbrt @samricotta @atheeshp @hieuvubk @likhita-809