Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Baseapp): Remove modules dependency from baseapp #19300

Merged
merged 6 commits into from Feb 1, 2024

Conversation

likhita-809
Copy link
Contributor

@likhita-809 likhita-809 commented Jan 31, 2024

Description

ref: #18290


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • Refactor
    • Streamlined end-to-end testing setup and improved test utility functions.
  • Chores
    • Updated Dockerfile for better integration with test environments.

@likhita-809 likhita-809 marked this pull request as ready for review January 31, 2024 06:33
@likhita-809 likhita-809 requested a review from a team as a code owner January 31, 2024 06:33
Copy link
Contributor

coderabbitai bot commented Jan 31, 2024

Walkthrough

The changes involve refactoring and cleanup of dependencies in the Cosmos SDK, specifically targeting the reduction of direct dependencies in the root go.mod file by moving certain functions and updating imports. This includes updating test utilities and Docker configurations to align with the new structure, aiming to streamline the SDK's dependency graph and improve modularity.

Changes

Files Change Summary
baseapp/block_gas_test.go, baseapp/utils_test.go Modified import statements and references to utilize baseapputil for GenesisStateWithSingleValidator, and removed several imports in utils_test.go.
contrib/images/simd-env/Dockerfile Updated to include tests/go.mod in the Docker environment.
tests/e2e/baseapp/utils.go Added GenesisStateWithSingleValidator function to initialize GenesisState with a single validator and accounts.

Assessment against linked issues

Objective Addressed Explanation
Remove cosmossdk.io/x/* dependence in the root go module (#18290) The changes in the PR indicate a consolidation and cleanup of dependencies, particularly through the use of baseapputil to avoid direct imports from cosmossdk.io/x/*. By modifying import paths and removing unnecessary dependencies in test files, the PR aligns with the objective of reducing the root module's dependency on Cosmos SDK's submodules. However, without seeing the entire scope of changes across all modules mentioned (Baseapp, Client, Server, Testutils), it's challenging to confirm full compliance.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

go.mod Outdated Show resolved Hide resolved
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julienrbrt julienrbrt added this pull request to the merge queue Feb 1, 2024
Merged via the queue into main with commit 6f180b2 Feb 1, 2024
58 of 59 checks passed
@julienrbrt julienrbrt deleted the likhita/remove-module-deps branch February 1, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants