Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spinout runtime module #62

Closed
wants to merge 1 commit into from
Closed

Conversation

odeke-em
Copy link
Contributor

@odeke-em odeke-em commented Nov 7, 2023

Creates a vanity URL for the cosmos-sdk package "runtime", accessible by URL "cosmossdk.io/runtime".

Updates cosmos/cosmos-sdk#18411

Creates a vanity URL for the cosmos-sdk package "runtime",
accessible by URL "cosmossdk.io/runtime".

Updates cosmos/cosmos-sdk#18411
@odeke-em odeke-em requested a review from a team as a code owner November 7, 2023 22:53
@odeke-em
Copy link
Contributor Author

odeke-em commented Nov 7, 2023

Kindly cc-ing @julienrbrt @tac0turtle

@julienrbrt
Copy link
Member

I don't think we should spin out runtime just yet. It will be modified with our server/app manager work.

@julienrbrt
Copy link
Member

julienrbrt commented Nov 7, 2023

Additionally, maybe we should slow down and start instead removing the circular dependencies in modules instead? I am currently doing the removal of bank as import in the SDK. But we have some modules importing each other as well for tests only, and we should delete that.

I am personally afraid that keeping pulling out stuff will before we get a dependency graph fixed will complicate our life.

ref: cosmos/cosmos-sdk#18290

@odeke-em
Copy link
Contributor Author

odeke-em commented Nov 7, 2023

Hey @julienrbrt sure I can help out with that dependency pruning but I wanted to ensure that I got this done once and for all so the PR is up cosmos/cosmos-sdk#18412. We can label it as "DO NOT MERGE" until we've cleared up dependencies in the go.mod file.

@julienrbrt julienrbrt closed this Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants