workflows: add stamp file in openshift/os to ensure we push rebases
#1776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The create-pull-request action currently only force-pushes branches if their diff has changed. However, if we've meanwhile landed a parallel fedora-coreos-config update PR via a different branch, the diff might be the same but the base commit will be different. We need to push the branch in this case too, or else the PR will be left unmergeable due to conflicts. As a workaround, write the base commit ID into a stamp file in the root of openshift/os, so the diff will change whenever the base does.
cgwalters
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
create-pull-requestaction currently only force-pushes branches if their diff has changed. However, if we've meanwhile landed a parallelfedora-coreos-configupdate PR via a different branch, the diff might be the same but the base commit will be different. We need to push the branch in this case too, or else the PR will be left unmergeable due to conflicts. As a workaround, write the base commit ID into a stamp file in the root ofopenshift/os, so the diff will change whenever the base does.Works around peter-evans/create-pull-request#1191.