Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump fedora-coreos-config #833

Closed
wants to merge 1 commit into from

Conversation

coreosbot-releng
Copy link

@coreosbot-releng coreosbot-releng commented Jun 8, 2022

Created by GitHub workflow (source).

Benjamin Gilbert (2):
      workflows: add scheduled job to sync openshift/os submodule
      workflows: add stamp file in openshift/os to ensure we push rebases

@bgilbert
Copy link
Contributor

bgilbert commented Jun 8, 2022

Marking draft for now in favor of the existing #807.

@bgilbert bgilbert marked this pull request as draft June 8, 2022 20:16
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 8, 2022
@openshift-ci openshift-ci bot requested review from jlebon and mike-nguyen June 8, 2022 20:17
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: coreosbot-releng
To complete the pull request process, please assign saqibali-2k after the PR has been reviewed.
You can assign the PR to them by writing /assign @saqibali-2k in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2022

Hi @coreosbot-releng. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bgilbert
Copy link
Contributor

bgilbert commented Jun 8, 2022

#807 landed. Lifting draft.

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 8, 2022
@bgilbert bgilbert marked this pull request as ready for review June 8, 2022 22:13
@openshift-ci openshift-ci bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jun 8, 2022
@openshift-ci openshift-ci bot requested review from marmijo and miabbott June 8, 2022 22:13
@cgwalters
Copy link
Member

Looks like we're missing the equivalent of @dependabot rebase.

@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 8, 2022
@bgilbert
Copy link
Contributor

bgilbert commented Jun 9, 2022

The job should be pushing a rebase, but isn't. Workaround in coreos/fedora-coreos-config#1776.

Benjamin Gilbert (2):
      workflows: add scheduled job to sync openshift/os submodule
      workflows: add stamp file in openshift/os to ensure we push rebases
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 9, 2022

@coreosbot-releng: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/test-in-cluster 1fdbf78 link true /test test-in-cluster

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bgilbert
Copy link
Contributor

bgilbert commented Jun 9, 2022

Closing to test openshift/release#29289.

@bgilbert bgilbert closed this Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants