plugin/trace: fix struct allignment #4112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A 64 bit entity needs to be the first in a struct to make it work on 32 bit systems. Fixes: #4111 Signed-off-by: Miek Gieben <miek@miek.nl>
Signed-off-by: Miek Gieben <miek@miek.nl>
Codecov Report
@@ Coverage Diff @@
## master #4112 +/- ##
==========================================
- Coverage 57.10% 57.05% -0.05%
==========================================
Files 222 222
Lines 11279 11280 +1
==========================================
- Hits 6441 6436 -5
- Misses 4346 4350 +4
- Partials 492 494 +2
Continue to review full report at Codecov.
|
zouyee
approved these changes
Sep 9, 2020
nyodas
pushed a commit
to DataDog/coredns
that referenced
this pull request
Oct 26, 2020
* plugin/trace: fix struct allignment A 64 bit entity needs to be the first in a struct to make it work on 32 bit systems. Fixes: coredns#4111 Signed-off-by: Miek Gieben <miek@miek.nl> * plugin/erratic does makes the same mistake Signed-off-by: Miek Gieben <miek@miek.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A 64 bit entity needs to be the first in a struct to make it work on 32
bit systems.
Fixes: #4111